drm: amdgpu: Fix includes of <linux/export.h>

[PATCH 0/2] drm: amdgpu: Fix includes of <linux/export.h>

Posted by André Almeida 3 months, 4 weeks ago

Commit 7d95680d64ac ("scripts/misc-check: check unnecessary #include
<linux/export.h> when W=1") and commit a934a57a42f6 ("scripts/misc-check:
check missing #include <linux/export.h> when W=1") added new checks for when the
include <linux/export.h> is missued by drivers. This patchset make drm/amd code
compliant to this new commits.

See also: https://lore.kernel.org/dri-devel/20250612121633.229222-1-tzimmermann@suse.de/

André Almeida (2):
  drm/amd: Do not include <linux/export.h> when unused
  drm/amd: Include <linux/export.h> when needed

 drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c      | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c   | 1 +
 drivers/gpu/drm/amd/amdkfd/kfd_chardev.c     | 1 -
 drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 -
 drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c  | 1 +
 5 files changed, 2 insertions(+), 3 deletions(-)

-- 
2.49.0

Re: [PATCH 0/2] drm: amdgpu: Fix includes of <linux/export.h>

Posted by Christian König 3 months, 3 weeks ago

Acked-by: Christian König <christian.koenig@amd.com> for the series.

On 6/13/25 20:26, André Almeida wrote:
> Commit 7d95680d64ac ("scripts/misc-check: check unnecessary #include
> <linux/export.h> when W=1") and commit a934a57a42f6 ("scripts/misc-check:
> check missing #include <linux/export.h> when W=1") added new checks for when the
> include <linux/export.h> is missued by drivers. This patchset make drm/amd code
> compliant to this new commits.
> 
> See also: https://lore.kernel.org/dri-devel/20250612121633.229222-1-tzimmermann@suse.de/
> 
> André Almeida (2):
>   drm/amd: Do not include <linux/export.h> when unused
>   drm/amd: Include <linux/export.h> when needed
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c      | 1 -
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c   | 1 +
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c     | 1 -
>  drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 -
>  drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c  | 1 +
>  5 files changed, 2 insertions(+), 3 deletions(-)
>

Re: [PATCH 0/2] drm: amdgpu: Fix includes of <linux/export.h>

Posted by André Almeida 3 months, 2 weeks ago

Hi Alex,

Em 16/06/2025 03:59, Christian König escreveu:
> Acked-by: Christian König <christian.koenig@amd.com> for the series.
> 

Can you add this series to amd-staging-drm-next? Thanks!

> On 6/13/25 20:26, André Almeida wrote:
>> Commit 7d95680d64ac ("scripts/misc-check: check unnecessary #include
>> <linux/export.h> when W=1") and commit a934a57a42f6 ("scripts/misc-check:
>> check missing #include <linux/export.h> when W=1") added new checks for when the
>> include <linux/export.h> is missued by drivers. This patchset make drm/amd code
>> compliant to this new commits.
>>
>> See also: https://lore.kernel.org/dri-devel/20250612121633.229222-1-tzimmermann@suse.de/
>>
>> André Almeida (2):
>>    drm/amd: Do not include <linux/export.h> when unused
>>    drm/amd: Include <linux/export.h> when needed
>>
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c      | 1 -
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c   | 1 +
>>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c     | 1 -
>>   drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 -
>>   drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c  | 1 +
>>   5 files changed, 2 insertions(+), 3 deletions(-)
>>
>

Re: [PATCH 0/2] drm: amdgpu: Fix includes of <linux/export.h>

Posted by Alex Deucher 3 months, 2 weeks ago

Applied.  Thanks!

On Tue, Jun 24, 2025 at 11:27 AM André Almeida <andrealmeid@igalia.com> wrote:
>
> Hi Alex,
>
> Em 16/06/2025 03:59, Christian König escreveu:
> > Acked-by: Christian König <christian.koenig@amd.com> for the series.
> >
>
> Can you add this series to amd-staging-drm-next? Thanks!
>
> > On 6/13/25 20:26, André Almeida wrote:
> >> Commit 7d95680d64ac ("scripts/misc-check: check unnecessary #include
> >> <linux/export.h> when W=1") and commit a934a57a42f6 ("scripts/misc-check:
> >> check missing #include <linux/export.h> when W=1") added new checks for when the
> >> include <linux/export.h> is missued by drivers. This patchset make drm/amd code
> >> compliant to this new commits.
> >>
> >> See also: https://lore.kernel.org/dri-devel/20250612121633.229222-1-tzimmermann@suse.de/
> >>
> >> André Almeida (2):
> >>    drm/amd: Do not include <linux/export.h> when unused
> >>    drm/amd: Include <linux/export.h> when needed
> >>
> >>   drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c      | 1 -
> >>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c   | 1 +
> >>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c     | 1 -
> >>   drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 -
> >>   drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c  | 1 +
> >>   5 files changed, 2 insertions(+), 3 deletions(-)
> >>
> >
>