arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Drop `bias-pull-up` from OVC pins

[PATCH] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Drop `bias-pull-up` from OVC pins

Posted by Prabhakar 8 months ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The USB20/21_OVRCUR pins on the RZ/V2H EVK has an external pull-up resistor
on the board. Therefore, the internal pull-up configuration via the
`bias-pull-up` property is redundant and should be removed.

Fixes: 7548897ad4ae3 ("arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable USB2.0 support")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
index 36e9f39cd4e4..9819f691c7d4 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
@@ -658,7 +658,6 @@ sd1_cd {
 	usb20_pins: usb20 {
 		ovc {
 			pinmux =  <RZV2H_PORT_PINMUX(9, 6, 14)>; /* OVC */
-			bias-pull-up;
 		};
 
 		vbus {
@@ -669,7 +668,6 @@ vbus {
 	usb21_pins: usb21 {
 		ovc {
 			pinmux = <RZV2H_PORT_PINMUX(6, 7, 14)>; /* OVC */
-			bias-pull-up;
 		};
 
 		vbus {
-- 
2.49.0

Re: [PATCH] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Drop `bias-pull-up` from OVC pins

Posted by Geert Uytterhoeven 7 months, 3 weeks ago

Hi Prabhakar,

On Fri, 13 Jun 2025 at 17:22, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The USB20/21_OVRCUR pins on the RZ/V2H EVK has an external pull-up resistor
> on the board. Therefore, the internal pull-up configuration via the
> `bias-pull-up` property is redundant and should be removed.

Thanks for your patch!

> Fixes: 7548897ad4ae3 ("arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable USB2.0 support")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
As I haven't sent a PR for this yet, I will fold it into the offending commit.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds