Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use
the helper instead to dedup the lines.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
mm/mmap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 09c563c95112..422f5b9d9660 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file,
unsigned long addr, unsigned long len,
unsigned long pgoff, unsigned long flags)
{
- if (test_bit(MMF_TOPDOWN, &mm->flags))
- return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0);
- return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0);
+ return mm_get_unmapped_area_vmflags(mm, file, addr, len,
+ pgoff, flags, 0);
}
EXPORT_SYMBOL(mm_get_unmapped_area);
--
2.49.0On Fri, 13 Jun 2025 09:41:07 -0400
Peter Xu <peterx@redhat.com> wrote:
> Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use
> the helper instead to dedup the lines.
Would it make more sense to make it an inline wrapper?
Moving the EXPORT_SYMBOL to mm_get_unmapped_area_vmflags.
David
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> mm/mmap.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 09c563c95112..422f5b9d9660 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file,
> unsigned long addr, unsigned long len,
> unsigned long pgoff, unsigned long flags)
> {
> - if (test_bit(MMF_TOPDOWN, &mm->flags))
> - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0);
> - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0);
> + return mm_get_unmapped_area_vmflags(mm, file, addr, len,
> + pgoff, flags, 0);
> }
> EXPORT_SYMBOL(mm_get_unmapped_area);
>
On Mon, Jun 16, 2025 at 09:01:34AM +0100, David Laight wrote: > On Fri, 13 Jun 2025 09:41:07 -0400 > Peter Xu <peterx@redhat.com> wrote: > > > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > > the helper instead to dedup the lines. > > Would it make more sense to make it an inline wrapper? > Moving the EXPORT_SYMBOL to mm_get_unmapped_area_vmflags. Yes, makes sense to me. However that seems to be better justified as a separate patch. If you wouldn't mind, I hope we can land the minimum version of the series first without expanding too much of what it touches. I already start to regret having the first two patches, but since I've posted, I'll carry them as of now. Please let me know if you have strong feelings. Thanks a lot for taking a look, -- Peter Xu
On 13.06.25 15:41, Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- Acked-by: David Hildenbrand <david@redhat.com> -- Cheers, David / dhildenb
You've not cc'd maintainers/reviewers of mm/mmap.c, please make sure to do so.
+cc Liam
+cc Vlastimiil
+cc Jann
+cc Pedro
...!
On Fri, Jun 13, 2025 at 09:41:07AM -0400, Peter Xu wrote:
> Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use
> the helper instead to dedup the lines.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
This looks fine though, so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> mm/mmap.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 09c563c95112..422f5b9d9660 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file,
> unsigned long addr, unsigned long len,
> unsigned long pgoff, unsigned long flags)
> {
> - if (test_bit(MMF_TOPDOWN, &mm->flags))
> - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0);
> - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0);
> + return mm_get_unmapped_area_vmflags(mm, file, addr, len,
> + pgoff, flags, 0);
> }
> EXPORT_SYMBOL(mm_get_unmapped_area);
>
> --
> 2.49.0
>
On Fri, Jun 13, 2025 at 04:57:12PM +0100, Lorenzo Stoakes wrote: > You've not cc'd maintainers/reviewers of mm/mmap.c, please make sure to do so. > > +cc Liam > +cc Vlastimiil > +cc Jann > +cc Pedro > > ...! > > On Fri, Jun 13, 2025 at 09:41:07AM -0400, Peter Xu wrote: > > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > > the helper instead to dedup the lines. > > > > Signed-off-by: Peter Xu <peterx@redhat.com> > > This looks fine though, so: > > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Reviewed-by: Pedro Falcato <pfalcato@suse.de> Looks good, thanks! -- Pedro
On 13 Jun 2025, at 9:41, Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > mm/mmap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Reviewed-by: Zi Yan <ziy@nvidia.com> Best Regards, Yan, Zi
On Fri, Jun 13, 2025 at 09:41:07AM -0400, Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. > > Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> -- Oscar Salvador SUSE Labs
On Fri, Jun 13, 2025 at 09:41:07AM -0400, Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > mm/mmap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
© 2016 - 2025 Red Hat, Inc.