[PATCH v2 5/7] regulator: tps6594-regulator: remove hardcoded buck config

Michael Walle posted 7 patches 3 months, 4 weeks ago
There is a newer version of this series
[PATCH v2 5/7] regulator: tps6594-regulator: remove hardcoded buck config
Posted by Michael Walle 3 months, 4 weeks ago
Commit 00c826525fba ("regulator: tps6594-regulator: Add TI TPS65224 PMIC
regulators") added support for the TPS65224 and made the description of
the multi-phase buck converter variable depending on the variant of the
PMIC. But this was just done for MUTLI_BUCK12 and MULTI_BUCK12_34
configs probably because this variant only supports a multi-phase
configuration on buck 1 and 2. Remove the hardcoded value for the
remaining two configs, too as future PMIC variants might also support
these.

This is a preparation patch to refactor the regulator description and
is compile-time only tested.

Signed-off-by: Michael Walle <mwalle@kernel.org>
---
 drivers/regulator/tps6594-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps6594-regulator.c b/drivers/regulator/tps6594-regulator.c
index 26669f3f1033..2c7c4df80695 100644
--- a/drivers/regulator/tps6594-regulator.c
+++ b/drivers/regulator/tps6594-regulator.c
@@ -695,14 +695,14 @@ static int tps6594_regulator_probe(struct platform_device *pdev)
 
 		if (i == MULTI_BUCK123 || i == MULTI_BUCK1234) {
 			error = tps6594_request_reg_irqs(pdev, rdev, irq_data,
-							 tps6594_bucks_irq_types[buck_idx + 2],
+							 bucks_irq_types[buck_idx + 2],
 							 nr_types, &irq_idx);
 			if (error)
 				return error;
 		}
 		if (i == MULTI_BUCK1234) {
 			error = tps6594_request_reg_irqs(pdev, rdev, irq_data,
-							 tps6594_bucks_irq_types[buck_idx + 3],
+							 bucks_irq_types[buck_idx + 3],
 							 nr_types, &irq_idx);
 			if (error)
 				return error;
-- 
2.39.5
Re: [PATCH v2 5/7] regulator: tps6594-regulator: remove hardcoded buck config
Posted by Mark Brown 3 months, 4 weeks ago
On Fri, Jun 13, 2025 at 01:45:16PM +0200, Michael Walle wrote:
> Commit 00c826525fba ("regulator: tps6594-regulator: Add TI TPS65224 PMIC
> regulators") added support for the TPS65224 and made the description of
> the multi-phase buck converter variable depending on the variant of the
> PMIC. But this was just done for MUTLI_BUCK12 and MULTI_BUCK12_34

Acked-by: Mark Brown <broonie@kernel.org>