drivers/mfd/tps6594-core.c | 88 ++++++++++- drivers/mfd/tps6594-i2c.c | 10 +- drivers/mfd/tps6594-spi.c | 10 +- drivers/misc/tps6594-pfsm.c | 31 ++-- drivers/pinctrl/pinctrl-tps6594.c | 35 ++++ drivers/regulator/tps6594-regulator.c | 219 +++++++++++++++----------- include/linux/mfd/tps6594.h | 1 + 7 files changed, 284 insertions(+), 110 deletions(-)
Add support for the TI TPS652G1 PMIC which is a stripped down version of the TPS65224. Support for the latter has already been merged. Refactor the regulator driver to ease adding new devices. After doing that adding the TPS652G1 variant is really straight forward. Some care has to be taken by the interrupt handling (of the regulator part) because there interrupts are used for voltage monitoring which this variant doesn't have. Michael Walle (7): mfd: tps6594: Add TI TPS652G1 support misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO regulator: tps6594-regulator: remove interrupt_count regulator: tps6594-regulator: remove hardcoded buck config regulator: tps6594-regulator: refactor variant descriptions regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators drivers/mfd/tps6594-core.c | 88 ++++++++++- drivers/mfd/tps6594-i2c.c | 10 +- drivers/mfd/tps6594-spi.c | 10 +- drivers/misc/tps6594-pfsm.c | 31 ++-- drivers/pinctrl/pinctrl-tps6594.c | 35 ++++ drivers/regulator/tps6594-regulator.c | 219 +++++++++++++++----------- include/linux/mfd/tps6594.h | 1 + 7 files changed, 284 insertions(+), 110 deletions(-) -- 2.39.5
On Fri, 13 Jun 2025, Michael Walle wrote: > Add support for the TI TPS652G1 PMIC which is a stripped down > version of the TPS65224. Support for the latter has already been > merged. Refactor the regulator driver to ease adding new devices. > After doing that adding the TPS652G1 variant is really straight > forward. Some care has to be taken by the interrupt handling (of the > regulator part) because there interrupts are used for voltage > monitoring which this variant doesn't have. > > Michael Walle (7): > mfd: tps6594: Add TI TPS652G1 support > misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM > pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO > regulator: tps6594-regulator: remove interrupt_count > regulator: tps6594-regulator: remove hardcoded buck config > regulator: tps6594-regulator: refactor variant descriptions > regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators > > drivers/mfd/tps6594-core.c | 88 ++++++++++- > drivers/mfd/tps6594-i2c.c | 10 +- > drivers/mfd/tps6594-spi.c | 10 +- > drivers/misc/tps6594-pfsm.c | 31 ++-- > drivers/pinctrl/pinctrl-tps6594.c | 35 ++++ > drivers/regulator/tps6594-regulator.c | 219 +++++++++++++++----------- > include/linux/mfd/tps6594.h | 1 + > 7 files changed, 284 insertions(+), 110 deletions(-) Doesn't apply. Please rebase onto v6.16-rc1. -- Lee Jones [李琼斯]
On Fri, 13 Jun 2025 13:45:11 +0200, Michael Walle wrote:
> Add support for the TI TPS652G1 PMIC which is a stripped down
> version of the TPS65224. Support for the latter has already been
> merged. Refactor the regulator driver to ease adding new devices.
> After doing that adding the TPS652G1 variant is really straight
> forward. Some care has to be taken by the interrupt handling (of the
> regulator part) because there interrupts are used for voltage
> monitoring which this variant doesn't have.
>
> [...]
Applied, thanks!
[1/7] mfd: tps6594: Add TI TPS652G1 support
commit: 626bb0a45584d544d84eab909795ccb355062bcc
[2/7] misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM
commit: 9cba6a7ebf65c603b80c0b3c7fa8c7c03f1b704c
[3/7] pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO
commit: f6420de1c810e282c34de65c70e6cc6177c12394
--
Lee Jones [李琼斯]
Enjoy!
The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:
Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17
for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee:
dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100)
----------------------------------------------------------------
Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window
----------------------------------------------------------------
Michael Walle (4):
mfd: tps6594: Add TI TPS652G1 support
misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM
pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO
dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC
.../devicetree/bindings/mfd/ti,tps6594.yaml | 1 +
drivers/mfd/tps6594-core.c | 88 ++++++++++++++++++++--
drivers/mfd/tps6594-i2c.c | 10 ++-
drivers/mfd/tps6594-spi.c | 10 ++-
drivers/misc/tps6594-pfsm.c | 31 +++++---
drivers/pinctrl/pinctrl-tps6594.c | 35 +++++++++
include/linux/mfd/tps6594.h | 1 +
7 files changed, 156 insertions(+), 20 deletions(-)The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:
Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17
for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee:
dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100)
----------------------------------------------------------------
Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window
----------------------------------------------------------------
Michael Walle (4):
mfd: tps6594: Add TI TPS652G1 support
misc: tps6594-pfsm: Add TI TPS652G1 PMIC PFSM
pinctrl: pinctrl-tps6594: Add TPS652G1 PMIC pinctrl and GPIO
dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC
.../devicetree/bindings/mfd/ti,tps6594.yaml | 1 +
drivers/mfd/tps6594-core.c | 88 ++++++++++++++++++++--
drivers/mfd/tps6594-i2c.c | 10 ++-
drivers/mfd/tps6594-spi.c | 10 ++-
drivers/misc/tps6594-pfsm.c | 31 +++++---
drivers/pinctrl/pinctrl-tps6594.c | 35 +++++++++
include/linux/mfd/tps6594.h | 1 +
7 files changed, 156 insertions(+), 20 deletions(-)
--
Lee Jones [李琼斯]
On Thu, Jul 10, 2025 at 11:49 AM Lee Jones <lee@kernel.org> wrote: > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: > > Linux 6.16-rc1 (2025-06-08 13:44:43 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17 > > for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee: > > dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100) > > ---------------------------------------------------------------- > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window Thanks for shepherding another successful MFD driver! I will optimistically assume that this merges in under the pinctrl umbrella without any snags, or that I can push any merge conflict into Torvalds' lap during the merge window, it usually works. Yours, Linus Walleij
On Thu, Jul 10, 2025 at 10:49:06AM +0100, Lee Jones wrote: > Enjoy! > > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: > > Linux 6.16-rc1 (2025-06-08 13:44:43 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17 > > for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee: > > dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100) > > ---------------------------------------------------------------- > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window Is there some reason you didn't also pick up the regulator patches?
On Thu, 10 Jul 2025, Mark Brown wrote: > On Thu, Jul 10, 2025 at 10:49:06AM +0100, Lee Jones wrote: > > Enjoy! > > > > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: > > > > Linux 6.16-rc1 (2025-06-08 13:44:43 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17 > > > > for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee: > > > > dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100) > > > > ---------------------------------------------------------------- > > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window > > Is there some reason you didn't also pick up the regulator patches? Is that a joke? I'm going to assume that you're not serious! https://lore.kernel.org/all/aCWfre2-n_PSuhxR@finisterre.sirena.org.uk/ "> 1. Apply this now and merge the dependents next cycle > 2. Apply this now and provide an IB > 3. Wait for all Acks and apply as a unified set > > We usually choose 3, hence my assumptions above. Well, you choose 3 - I do think it'd be a lot easier to go with option 2, or with applying the rest to your tree as acks come in. There seemed to still be a reasonable amount of discussion on the MFD bits (eg, there's some formatting comments still) so I was expecting this series to churn some more and was waiting for a resend." https://lore.kernel.org/all/601dd4c7-0940-498b-815e-99e570e732d2@sirena.org.uk/ "So not apply the first two patches and share a branch like you said above... TBH these serieses would probably be a bit more legible if the branch were created with just the MFD patches, that'd also mean smaller cross merges." IRC: "<b*****e> Probably the easiest thing is a tag with the MFD bits and then I can apply the regulator patches?" Etc ... -- Lee Jones [李琼斯]
On Fri, Jul 18, 2025 at 08:13:44AM +0100, Lee Jones wrote: > On Thu, 10 Jul 2025, Mark Brown wrote: > > On Thu, Jul 10, 2025 at 10:49:06AM +0100, Lee Jones wrote: > > > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window > > Is there some reason you didn't also pick up the regulator patches? > Is that a joke? I'm going to assume that you're not serious! There's two things here. One is that the discussions you've linked were from back in April/May which was before the merge window and things only got applied a day or two before the merge window opened. Then rather than resending after the merge window as expected whoever it was complained about the patches not being applied just did that with no further context and it didn't occur to me to look at the date and as a result I missed that, sorry. The other issue is that due to the constant drip of MFD serieses getting resends what I'm doing I'm just glancing at the relevant patches and then not looking further if I've already reviewed them. I frequently have no recollection of any individual series, especially if there's been non-trivial time since I actively looked at it.
On Fri, 18 Jul 2025, Mark Brown wrote: > On Fri, Jul 18, 2025 at 08:13:44AM +0100, Lee Jones wrote: > > On Thu, 10 Jul 2025, Mark Brown wrote: > > > On Thu, Jul 10, 2025 at 10:49:06AM +0100, Lee Jones wrote: > > > > > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window > > > > Is there some reason you didn't also pick up the regulator patches? > > > Is that a joke? I'm going to assume that you're not serious! > > There's two things here. One is that the discussions you've linked were > from back in April/May which was before the merge window and things only > got applied a day or two before the merge window opened. Then rather > than resending after the merge window as expected whoever it was > complained about the patches not being applied just did that with no > further context and it didn't occur to me to look at the date and as a > result I missed that, sorry. > > The other issue is that due to the constant drip of MFD serieses getting > resends what I'm doing I'm just glancing at the relevant patches and > then not looking further if I've already reviewed them. I frequently > have no recollection of any individual series, especially if there's > been non-trivial time since I actively looked at it. This is bigger than these particular series. There are more examples, but I stopped at the three most recent ones. For the past decade or so I've been taking cross-subsystem patch-sets and submitting pull-requests to all other maintainers, after testing of course. However, more recently you have become increasingly vocal in terms of an alternative approach, whereby I apply the set without patches that pertain to your AoR (usually Regulators) and submit an immutable branch for you to pull from. I have attempted both recently and each has received criticism, showing preference for the other. Honestly, I don't mind which strategy we put into place. Let's just agree on one and go with it. -- Lee Jones [李琼斯]
On Fri, Jul 18, 2025 at 02:38:46PM +0100, Lee Jones wrote: > For the past decade or so I've been taking cross-subsystem patch-sets > and submitting pull-requests to all other maintainers, after testing of > course. However, more recently you have become increasingly vocal in > terms of an alternative approach, whereby I apply the set without > patches that pertain to your AoR (usually Regulators) and submit an > immutable branch for you to pull from. I have attempted both recently > and each has received criticism, showing preference for the other. > Honestly, I don't mind which strategy we put into place. Let's just > agree on one and go with it. What I'm expecting is that if I've reviewed/acked something then it'd be applied but that if the MFD stuff is good to go then that gets applied as is and any remaining patches get handled separately. This was a weird case where I'd reviewed the patches without realising there were dependencies, and those deps weren't an issue whenever someone sent a ping.
Hi, On Thu Jul 10, 2025 at 11:57 AM CEST, Mark Brown wrote: > On Thu, Jul 10, 2025 at 10:49:06AM +0100, Lee Jones wrote: > > Enjoy! > > > > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: > > > > Linux 6.16-rc1 (2025-06-08 13:44:43 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-misc-pinctrl-v6.17 > > > > for you to fetch changes up to d90171bc2e5f69c038d1807e6f64fba3d1ad6bee: > > > > dt-bindings: mfd: ti,tps6594: Add TI TPS652G1 PMIC (2025-07-10 10:40:21 +0100) > > > > ---------------------------------------------------------------- > > Immutable branch between MFD, Misc and Pinctrl due for the v6.17 merge window > > Is there some reason you didn't also pick up the regulator patches? The regulator patches don't apply on the MFD tree because there are two new patches [1, 2] in the regulator tree. Also my patches rely on them. Thus, the idea was that Lee will provide an immutable tag, that you can pull together with the remaining regulator patches. -michael https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator/tps6594-regulator.c?id=9bb3c7df546aac38ea64c736a839ef2c75297631 https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator/tps6594-regulator.c?id=c266209eaef4fef863363557817f7d6a68314321
On Thu, Jul 10, 2025 at 12:46:52PM +0200, Michael Walle wrote: > On Thu Jul 10, 2025 at 11:57 AM CEST, Mark Brown wrote: > > Is there some reason you didn't also pick up the regulator patches? > The regulator patches don't apply on the MFD tree because there are > two new patches [1, 2] in the regulator tree. Also my patches rely > on them. Thus, the idea was that Lee will provide an immutable tag, > that you can pull together with the remaining regulator patches. OK, if there's a situation like this then please don't send the patches that can't be applied, that way maintainers for the other trees don't need to see all the resends for something they can't act on. Instead ask for the teg, then send a pull request for the tag as part of the cover letter for the series with the additional patches.
© 2016 - 2025 Red Hat, Inc.