[v5] media: rc: ir-spi: allocate buffer dynamically

[PATCH v5 0/3] media: rc: ir-spi: allocate buffer dynamically

Posted by Cosmin Tanislav 3 months, 4 weeks ago

Replace the static transmit buffer with a dynamically allocated one,
removing the limit imposed on the number of pulses to transmit.

Add a check to constrain the carrier frequency inside
ir_spi_set_tx_carrier().

Switch to u64 arithmetic to ir_spi_tx() when calculating the number
of pulses to transmit.

V5:
 * add separate patch to solve overflow issues in ir_spi_tx()
 * avoid overflow in carrier frequency constraint

V4:
 * add separate patch to constrain the carrier frequency

V3:
 * move the allocation to be done per-TX operation

V2:
 * use devm_krealloc_array

Cosmin Tanislav (3):
  media: rc: ir-spi: allocate buffer dynamically
  media: rc: ir-spi: constrain carrier frequency
  media: rc: ir-spi: avoid overflow in multiplication

 drivers/media/rc/ir-spi.c | 40 +++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

-- 
2.49.0

Re: [PATCH v5 0/3] media: rc: ir-spi: allocate buffer dynamically

Posted by Sean Young 3 months, 3 weeks ago

On Fri, Jun 13, 2025 at 02:21:50PM +0300, Cosmin Tanislav wrote:
> Replace the static transmit buffer with a dynamically allocated one,
> removing the limit imposed on the number of pulses to transmit.
> 
> Add a check to constrain the carrier frequency inside
> ir_spi_set_tx_carrier().
> 
> Switch to u64 arithmetic to ir_spi_tx() when calculating the number
> of pulses to transmit.

Looks good, I've created a PR to have it merged.

Sean

> 
> V5:
>  * add separate patch to solve overflow issues in ir_spi_tx()
>  * avoid overflow in carrier frequency constraint
> 
> V4:
>  * add separate patch to constrain the carrier frequency
> 
> V3:
>  * move the allocation to be done per-TX operation
> 
> V2:
>  * use devm_krealloc_array
> 
> Cosmin Tanislav (3):
>   media: rc: ir-spi: allocate buffer dynamically
>   media: rc: ir-spi: constrain carrier frequency
>   media: rc: ir-spi: avoid overflow in multiplication
> 
>  drivers/media/rc/ir-spi.c | 40 +++++++++++++++++++++++++--------------
>  1 file changed, 26 insertions(+), 14 deletions(-)
> 
> -- 
> 2.49.0
>