fpga: altera-cvp: Add FPGA Configuration Framework dependency

[PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency

Posted by Kuhanh Murugasen Krishnan 3 months, 4 weeks ago

From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>

Altera CvP FPGA Manager driver depends on FPGA
Configuration Framework drivers to be loaded in
the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
depends on to include FPGA.

Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
---
 drivers/fpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 37b35f58f0df..6f741348bfbc 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
 
 config FPGA_MGR_ALTERA_CVP
 	tristate "Altera CvP FPGA Manager"
-	depends on PCI
+	depends on PCI && FPGA
 	help
 	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
 	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.
-- 
2.25.1

Re: [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency

Posted by Xu Yilun 3 months ago

On Fri, Jun 13, 2025 at 05:24:14PM +0800, Kuhanh Murugasen Krishnan wrote:
> From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>
> 
> Altera CvP FPGA Manager driver depends on FPGA
> Configuration Framework drivers to be loaded in
> the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
> depends on to include FPGA.

Is that necessary? We've already included all FPGA drivers in "if FPGA".

Thanks,
Yilun

> 
> Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
> ---
>  drivers/fpga/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 37b35f58f0df..6f741348bfbc 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
>  
>  config FPGA_MGR_ALTERA_CVP
>  	tristate "Altera CvP FPGA Manager"
> -	depends on PCI
> +	depends on PCI && FPGA
>  	help
>  	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
>  	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.
> -- 
> 2.25.1
> 
>

Re: [PATCH] fpga: altera-cvp: Add FPGA Configuration Framework dependency

Posted by Matthew Gerlach 3 months, 4 weeks ago


On 6/13/25 2:24 AM, Kuhanh Murugasen Krishnan wrote:
> From: "Murugasen Krishnan, Kuhanh" <kuhanh.murugasen.krishnan@altera.com>
Hi Murugasen Krishnan,

You should check your .gitconfig because your patch was from 
kuhanh.murugasen.krishnan@intel.com, but your Signed-off-by: says 
altera.com.

Matthew Gerlach
>
> Altera CvP FPGA Manager driver depends on FPGA
> Configuration Framework drivers to be loaded in
> the kernel. Updating FPGA_MGR_ALTERA_CVP in Kconfig
> depends on to include FPGA.
>
> Signed-off-by: Murugasen Krishnan, Kuhanh <kuhanh.murugasen.krishnan@altera.com>
> ---
>   drivers/fpga/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 37b35f58f0df..6f741348bfbc 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -47,7 +47,7 @@ config FPGA_MGR_ALTERA_PS_SPI
>   
>   config FPGA_MGR_ALTERA_CVP
>   	tristate "Altera CvP FPGA Manager"
> -	depends on PCI
> +	depends on PCI && FPGA
>   	help
>   	  FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V,
>   	  Arria 10 and Stratix10 Altera FPGAs using the CvP interface over PCIe.