[PATCH 0/3] pci: cx23885: Convert to use string choices helper

Pan Chuang posted 3 patches 3 months, 4 weeks ago
drivers/media/pci/cx23885/altera-ci.c  |  2 +-
drivers/media/pci/cx23885/cimax2.c     |  2 +-
drivers/media/pci/cx23885/cx23888-ir.c | 36 +++++++++++++-------------
3 files changed, 20 insertions(+), 20 deletions(-)
[PATCH 0/3] pci: cx23885: Convert to use string choices helper
Posted by Pan Chuang 3 months, 4 weeks ago
Remove hard-coded strings by using the str_read_write(),
str_yes_no() and str_enabled_disabled() helper.

Pan Chuang (3):
  pci: cx23885: altera-ci: Use str_read_write() helper
  pci: cx23885: cimax2: Use str_read_write() helper
  pci: cx23885: cx23888-ir: Use str_yes_no() and str_enabled_disabled()
    helper

 drivers/media/pci/cx23885/altera-ci.c  |  2 +-
 drivers/media/pci/cx23885/cimax2.c     |  2 +-
 drivers/media/pci/cx23885/cx23888-ir.c | 36 +++++++++++++-------------
 3 files changed, 20 insertions(+), 20 deletions(-)

-- 
2.39.0
Re: [PATCH 0/3] pci: cx23885: Convert to use string choices helper
Posted by Hans Verkuil 3 months, 3 weeks ago
Hi Pan Chuang,

On 13/06/2025 10:21, Pan Chuang wrote:
> Remove hard-coded strings by using the str_read_write(),
> str_yes_no() and str_enabled_disabled() helper.
> 
> Pan Chuang (3):
>   pci: cx23885: altera-ci: Use str_read_write() helper
>   pci: cx23885: cimax2: Use str_read_write() helper
>   pci: cx23885: cx23888-ir: Use str_yes_no() and str_enabled_disabled()
>     helper

The opinion of the media maintainers is that there is very little gain
in changing this in existing code. For new drivers it is fine, but for
these old drivers we prefer to just leave it as-is.

So I'll drop this series and the cobalt patch.

Regards,

	Hans

> 
>  drivers/media/pci/cx23885/altera-ci.c  |  2 +-
>  drivers/media/pci/cx23885/cimax2.c     |  2 +-
>  drivers/media/pci/cx23885/cx23888-ir.c | 36 +++++++++++++-------------
>  3 files changed, 20 insertions(+), 20 deletions(-)
>