[PATCH v5 0/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep

David Lechner posted 3 patches 3 months, 4 weeks ago
drivers/bus/ts-nbus.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
[PATCH v5 0/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep
Posted by David Lechner 3 months, 4 weeks ago
This is what remains from "gpiolib: add gpiod_multi_set_value_cansleep"
that didn't get applied yet for the bus subsystem. So I have changed
the subject line accordingly.

Arnd,

There was no maintainer listed in MAINTAINERS for the ts-nbus driver
and it looks like you have picked up patches for it in the past. Could
you please pick up these as well?

---
Changes in v5:
- Fix undeclared variable in ts_nbus_reset_bus()
- Link to v4: https://lore.kernel.org/r/20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com

Changes in v4:
- Dropped all non-ts-nbus patches.
- Fixed a reported issue with uninitialized variables.
- Link to v3: https://lore.kernel.org/r/20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com

Changes in v3:
- Added IS_ERR_OR_NULL() check to gpiod_multi_set_value_cansleep()
- Added new patches to clean up accessing bitmap directly (ts-nbus, ad2s1210).
- Added function prefix for max3191x.
- Removed unnecessary braces in ad7606 patch.
- Picked up additional trailers.
- Link to v2: https://lore.kernel.org/r/20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com

Changes in v2:
- Renamed new function from gpiods_multi_set_value_cansleep() to
  gpiod_multi_set_value_cansleep()
- Fixed typo in name of replaced function in all commit messages.
- Picked up trailers.
- Link to v1: https://lore.kernel.org/r/20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com

---
David Lechner (3):
      bus: ts-nbus: validate ts,data-gpios array size
      bus: ts-nbus: use gpiod_multi_set_value_cansleep
      bus: ts-nbus: use bitmap_set_value8()

 drivers/bus/ts-nbus.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
---
base-commit: 19a60293b9925080d97f22f122aca3fc46dadaf9
change-id: 20250131-gpio-set-array-helper-bd4a328370d3

Best regards,
-- 
David Lechner <dlechner@baylibre.com>
Re: [PATCH v5 0/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep
Posted by Arnd Bergmann 3 months, 4 weeks ago
On Fri, Jun 13, 2025, at 20:55, David Lechner wrote:
> This is what remains from "gpiolib: add gpiod_multi_set_value_cansleep"
> that didn't get applied yet for the bus subsystem. So I have changed
> the subject line accordingly.
>
> Arnd,
>
> There was no maintainer listed in MAINTAINERS for the ts-nbus driver
> and it looks like you have picked up patches for it in the past. Could
> you please pick up these as well?

Sure, no problem, just a few things:

- These are all cleanups that can wait until 6.17, right?
- I see the driver has no in-tree users, and apparently never
  were. There is a imx28-ts4600.dts file that should reference
  it but doesn't. Do we have any indication that the driver works?
  Added Sebastien to Cc as well for clarification.
- it would help me if you can send the patches to soc@kernel.org
  for me to pick up, as that ensures I don't forget them.

     Arnd
Re: [PATCH v5 0/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep
Posted by David Lechner 3 months, 4 weeks ago
On 6/13/25 3:37 PM, Arnd Bergmann wrote:
> On Fri, Jun 13, 2025, at 20:55, David Lechner wrote:
>> This is what remains from "gpiolib: add gpiod_multi_set_value_cansleep"
>> that didn't get applied yet for the bus subsystem. So I have changed
>> the subject line accordingly.
>>
>> Arnd,
>>
>> There was no maintainer listed in MAINTAINERS for the ts-nbus driver
>> and it looks like you have picked up patches for it in the past. Could
>> you please pick up these as well?
> 
> Sure, no problem, just a few things:
> 
> - These are all cleanups that can wait until 6.17, right?

yes

> - I see the driver has no in-tree users, and apparently never
>   were. There is a imx28-ts4600.dts file that should reference
>   it but doesn't. Do we have any indication that the driver works?
>   Added Sebastien to Cc as well for clarification.

I dropped Sebastien in v5 because the emails bounced in v4, so I
don't expect we will get a response. I'm not familiar with this
driver or related hardware myself.

> - it would help me if you can send the patches to soc@kernel.org
>   for me to pick up, as that ensures I don't forget them.
> 
>      Arnd