[PATCH v3 16/44] thermal: intel: Reorder headers alphabetically

Ahmed S. Darwish posted 44 patches 3 months, 4 weeks ago
There is a newer version of this series
[PATCH v3 16/44] thermal: intel: Reorder headers alphabetically
Posted by Ahmed S. Darwish 3 months, 4 weeks ago
The source file uses cpuid_*() macros, but it does not include
<asm/cpuid/api.h>.  Sort its include lines so that the CPUID header can
be included next.

Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
---
 drivers/thermal/intel/x86_pkg_temp_thermal.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/thermal/intel/x86_pkg_temp_thermal.c b/drivers/thermal/intel/x86_pkg_temp_thermal.c
index 3fc679b6f11b..c843cb5fc5c3 100644
--- a/drivers/thermal/intel/x86_pkg_temp_thermal.c
+++ b/drivers/thermal/intel/x86_pkg_temp_thermal.c
@@ -5,19 +5,19 @@
  */
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/module.h>
+#include <linux/cpu.h>
+#include <linux/debugfs.h>
+#include <linux/device.h>
+#include <linux/err.h>
 #include <linux/init.h>
 #include <linux/intel_tcc.h>
-#include <linux/err.h>
+#include <linux/module.h>
 #include <linux/param.h>
-#include <linux/device.h>
 #include <linux/platform_device.h>
-#include <linux/cpu.h>
-#include <linux/smp.h>
-#include <linux/slab.h>
 #include <linux/pm.h>
+#include <linux/slab.h>
+#include <linux/smp.h>
 #include <linux/thermal.h>
-#include <linux/debugfs.h>
 
 #include <asm/cpu_device_id.h>
 #include <asm/msr.h>
-- 
2.49.0
Re: [PATCH v3 16/44] thermal: intel: Reorder headers alphabetically
Posted by Borislav Petkov 3 months, 1 week ago
On Fri, Jun 13, 2025 at 01:39:42AM +0200, Ahmed S. Darwish wrote:
> The source file uses cpuid_*() macros, but it does not include
> <asm/cpuid/api.h>.  Sort its include lines so that the CPUID header can
> be included next.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
> ---
>  drivers/thermal/intel/x86_pkg_temp_thermal.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Can we merge all those silly includes sorting patches into a single, per-topic
or per-tree patch respectively please?

A single includes sorting patch is fine too since the whole pile will go
through tip eventually.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH v3 16/44] thermal: intel: Reorder headers alphabetically
Posted by Ahmed S. Darwish 3 months ago
On Fri, 04 Jul 2025, Borislav Petkov wrote:
>
> Can we merge all those silly includes sorting patches into a single,
> per-topic or per-tree patch respectively please?
>
> A single includes sorting patch is fine too since the whole pile will
> go through tip eventually.
>

Sure, will do.