[PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return

Steven Rostedt posted 14 patches 3 months, 4 weeks ago
[PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return
Posted by Steven Rostedt 3 months, 4 weeks ago
From: Steven Rostedt <rostedt@goodmis.org>

When the function xfs_attri_remove_iter was removed, it did not remove the
trace event that it called. As a trace event can take up to 5K of memory for
text and meta data regardless of if it is used or not, remove this unused trace
event.

Fixes: 59782a236b62 ("xfs: remove xfs_attri_remove_iter")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index ae0ed0dd0a01..67bdcab9ff47 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -5076,7 +5076,6 @@ DEFINE_DAS_STATE_EVENT(xfs_attr_sf_addname_return);
 DEFINE_DAS_STATE_EVENT(xfs_attr_set_iter_return);
 DEFINE_DAS_STATE_EVENT(xfs_attr_leaf_addname_return);
 DEFINE_DAS_STATE_EVENT(xfs_attr_node_addname_return);
-DEFINE_DAS_STATE_EVENT(xfs_attr_remove_iter_return);
 DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_alloc);
 DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_remove_return);
 DEFINE_DAS_STATE_EVENT(xfs_attr_defer_add);
-- 
2.47.2
Re: [PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return
Posted by Christoph Hellwig 3 months, 3 weeks ago
Please lover case the start of the commit message after the subsystem
prefix like other xfs commits.  The Subject line / one line summary
is not a sentence.  Same for all the other pathes.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Re: [PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return
Posted by Steven Rostedt 3 months, 3 weeks ago
On Mon, 16 Jun 2025 07:26:45 +0200
Christoph Hellwig <hch@lst.de> wrote:

> Please lover case the start of the commit message after the subsystem

OK.

> prefix like other xfs commits.  The Subject line / one line summary
> is not a sentence.  Same for all the other pathes.
> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks,

-- Steve