xfs: actually use the xfs_growfs_check_rtgeom tracepoint

[PATCH] xfs: actually use the xfs_growfs_check_rtgeom tracepoint

Posted by Darrick J. Wong 3 months, 4 weeks ago

From: Darrick J. Wong <djwong@kernel.org>

We created a new tracepoint but forgot to put it in.  Fix that.

Cc: rostedt@goodmis.org
Cc: <stable@vger.kernel.org> # v6.14
Fixes: 59a57acbce282d ("xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 fs/xfs/xfs_rtalloc.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 6484c596eceaf2..736eb0924573d3 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -1259,6 +1259,8 @@ xfs_growfs_check_rtgeom(
 
 	kfree(nmp);
 
+	trace_xfs_growfs_check_rtgeom(mp, min_logfsbs);
+
 	if (min_logfsbs > mp->m_sb.sb_logblocks)
 		return -EINVAL;

Re: [PATCH] xfs: actually use the xfs_growfs_check_rtgeom tracepoint

Posted by Carlos Maiolino 3 months, 3 weeks ago

On Thu, 12 Jun 2025 10:51:12 -0700, Darrick J. Wong wrote:
> We created a new tracepoint but forgot to put it in.  Fix that.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: actually use the xfs_growfs_check_rtgeom tracepoint
      commit: db44d088a5ab030b741a3adf2e7b181a8a6dcfbe

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>

Re: [PATCH] xfs: actually use the xfs_growfs_check_rtgeom tracepoint

Posted by Carlos Maiolino 3 months, 3 weeks ago

On Thu, Jun 12, 2025 at 10:51:12AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> We created a new tracepoint but forgot to put it in.  Fix that.
> 

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> Cc: rostedt@goodmis.org
> Cc: <stable@vger.kernel.org> # v6.14
> Fixes: 59a57acbce282d ("xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs")
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  fs/xfs/xfs_rtalloc.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 6484c596eceaf2..736eb0924573d3 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -1259,6 +1259,8 @@ xfs_growfs_check_rtgeom(
> 
>  	kfree(nmp);
> 
> +	trace_xfs_growfs_check_rtgeom(mp, min_logfsbs);
> +
>  	if (min_logfsbs > mp->m_sb.sb_logblocks)
>  		return -EINVAL;
>

Re: [PATCH] xfs: actually use the xfs_growfs_check_rtgeom tracepoint

Posted by Steven Rostedt 3 months, 4 weeks ago

On Thu, 12 Jun 2025 10:51:12 -0700
"Darrick J. Wong" <djwong@kernel.org> wrote:

> From: Darrick J. Wong <djwong@kernel.org>
> 
> We created a new tracepoint but forgot to put it in.  Fix that.
> 
> Cc: rostedt@goodmis.org
> Cc: <stable@vger.kernel.org> # v6.14
> Fixes: 59a57acbce282d ("xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs")

May want to also add:

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Closes: https://lore.kernel.org/all/20250612131021.114e6ec8@batman.local.home/

Thanks,

-- Steve

> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  fs/xfs/xfs_rtalloc.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 6484c596eceaf2..736eb0924573d3 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -1259,6 +1259,8 @@ xfs_growfs_check_rtgeom(
>  
>  	kfree(nmp);
>  
> +	trace_xfs_growfs_check_rtgeom(mp, min_logfsbs);
> +
>  	if (min_logfsbs > mp->m_sb.sb_logblocks)
>  		return -EINVAL;
>