rust/kernel/cpufreq.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Update the `bios_limit_callback` function to use `c_int` and `c_uint` types,
which match the C ABI for the corresponding callback function. These types are
imported from the prelude.
This change ensures the Rust function signature exactly matches its expected
C counterpart, avoiding potential issues with type mismatches in the FFI
boundary.
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Closes: https://lore.kernel.org/rust-for-linux/CANiq72=WpuGELzLbH-fxdOeJy9fiDFwatz6ynERDh=HP2z2MBw@mail.gmail.com/.
Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
---
rust/kernel/cpufreq.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs
index b0a9c6182aec..e97607ed86c2 100644
--- a/rust/kernel/cpufreq.rs
+++ b/rust/kernel/cpufreq.rs
@@ -1277,7 +1277,7 @@ extern "C" fn update_limits_callback(ptr: *mut bindings::cpufreq_policy) {
/// Driver's `bios_limit` callback.
///
/// SAFETY: Called from C. Inputs must be valid pointers.
- extern "C" fn bios_limit_callback(cpu: i32, limit: *mut u32) -> kernel::ffi::c_int {
+ extern "C" fn bios_limit_callback(cpu: c_int, limit: *mut c_uint) -> c_int {
from_result(|| {
let mut policy = PolicyCpu::from_cpu(cpu as u32)?;
--
2.34.1
On Thu, Jun 12, 2025 at 12:43 PM Abhinav Ananthu <abhinav.ogl@gmail.com> wrote: > > Update the `bios_limit_callback` function to use `c_int` and `c_uint` types, > which match the C ABI for the corresponding callback function. These types are > imported from the prelude. > > This change ensures the Rust function signature exactly matches its expected > C counterpart, avoiding potential issues with type mismatches in the FFI > boundary. > > Reported-by: Miguel Ojeda <ojeda@kernel.org> > Closes: https://lore.kernel.org/rust-for-linux/CANiq72=WpuGELzLbH-fxdOeJy9fiDFwatz6ynERDh=HP2z2MBw@mail.gmail.com/. > Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com> This seems to be a duplicate email. Cheers, Miguel
© 2016 - 2025 Red Hat, Inc.