alarmtimer: Hide alarmtimer_suspend event when RTC_CLASS is not configured

[PATCH] alarmtimer: Hide alarmtimer_suspend event when RTC_CLASS is not configured

Posted by Steven Rostedt 4 months ago

From: Steven Rostedt <rostedt@goodmis.org>

The trace event alarmtimer_suspend is only called when RTC_CLASS is not
defined. As every event created can create up to 5K of text and meta data
regardless if it is called or not it should not be created and waste
memory. Hide the event when CONFIG_RTC_CLASS is not defined.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Note, I will be adding code soon that will make unused events cause a warning.

 include/trace/events/alarmtimer.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/trace/events/alarmtimer.h b/include/trace/events/alarmtimer.h
index 13483c7ca70b..8e9c76a7f21b 100644
--- a/include/trace/events/alarmtimer.h
+++ b/include/trace/events/alarmtimer.h
@@ -20,6 +20,7 @@ TRACE_DEFINE_ENUM(ALARM_BOOTTIME_FREEZER);
 	{ 1 << ALARM_REALTIME_FREEZER, "REALTIME Freezer" },	\
 	{ 1 << ALARM_BOOTTIME_FREEZER, "BOOTTIME Freezer" })
 
+#ifdef CONFIG_RTC_CLASS
 TRACE_EVENT(alarmtimer_suspend,
 
 	TP_PROTO(ktime_t expires, int flag),
@@ -41,6 +42,7 @@ TRACE_EVENT(alarmtimer_suspend,
 		  __entry->expires
 	)
 );
+#endif /* CONFIG_RTC_CLASS */
 
 DECLARE_EVENT_CLASS(alarm_class,
 
-- 
2.47.2

Re: [PATCH] alarmtimer: Hide alarmtimer_suspend event when RTC_CLASS is not configured

Posted by Thomas Gleixner 3 months, 4 weeks ago

On Thu, Jun 12 2025 at 09:58, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> The trace event alarmtimer_suspend is only called when RTC_CLASS is not
> defined.

s/not//

No?

> As every event created can create up to 5K of text and meta data
> regardless if it is called or not it should not be created and waste
> memory. Hide the event when CONFIG_RTC_CLASS is not defined.
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Other than that:

Acked-by: Thomas Gleixner <tglx@linutronix.de>

Re: [PATCH] alarmtimer: Hide alarmtimer_suspend event when RTC_CLASS is not configured

Posted by Steven Rostedt 3 months, 3 weeks ago

On Fri, 13 Jun 2025 18:44:33 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Thu, Jun 12 2025 at 09:58, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> >
> > The trace event alarmtimer_suspend is only called when RTC_CLASS is not
> > defined.  
> 
> s/not//
> 
> No?

Ah yeah.

> 
> > As every event created can create up to 5K of text and meta data
> > regardless if it is called or not it should not be created and waste
> > memory. Hide the event when CONFIG_RTC_CLASS is not defined.
> >
> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>  
> 
> Other than that:
> 
> Acked-by: Thomas Gleixner <tglx@linutronix.de>

Thanks!

-- Steve