[PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support

Kaustabh Chakraborty posted 5 patches 4 months ago
There is a newer version of this series
[PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support
Posted by Kaustabh Chakraborty 4 months ago
Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, disable the
simple-framebuffer node in favor of the panel.

This device has a 1080x1920 Synaptics TD4300 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
index eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
@@ -40,6 +40,8 @@ framebuffer@67000000 {
 			height = <1920>;
 			stride = <(1080 * 4)>;
 			format = "a8r8g8b8";
+
+			status = "disabled";
 		};
 	};
 
@@ -122,6 +124,44 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <1001000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	panel@0 {
+		compatible = "syna,td4300-panel";
+		reg = <0>;
+
+		backlight-gpios = <&gpd3 5 GPIO_ACTIVE_LOW>;
+
+		width-mm = <68>;
+		height-mm = <121>;
+
+		panel-timing {
+			clock-frequency = <144389520>;
+
+			hactive = <1080>;
+			hsync-len = <4>;
+			hfront-porch = <120>;
+			hback-porch = <32>;
+
+			vactive = <1920>;
+			vsync-len = <2>;
+			vfront-porch = <21>;
+			vback-porch = <4>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0
Re: [PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support
Posted by Krzysztof Kozlowski 3 months, 3 weeks ago
On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
> Enable DECON and DSI nodes, and add the compatible display panel and
> appropriate panel timings for this device. Also, disable the
> simple-framebuffer node in favor of the panel.
> 
> This device has a 1080x1920 Synaptics TD4300 display panel.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 ++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> index eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> @@ -40,6 +40,8 @@ framebuffer@67000000 {
>  			height = <1920>;
>  			stride = <(1080 * 4)>;
>  			format = "a8r8g8b8";
> +
> +			status = "disabled";

This should be rather removed. What is the idea behind keeping disabled
node?


Best regards,
Krzysztof
Re: [PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support
Posted by Kaustabh Chakraborty 3 months, 3 weeks ago
On 2025-06-18 09:57, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Enable DECON and DSI nodes, and add the compatible display panel and
>> appropriate panel timings for this device. Also, disable the
>> simple-framebuffer node in favor of the panel.
>> 
>> This device has a 1080x1920 Synaptics TD4300 display panel.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 
>> ++++++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts 
>> b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> index 
>> eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 
>> 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> @@ -40,6 +40,8 @@ framebuffer@67000000 {
>>  			height = <1920>;
>>  			stride = <(1080 * 4)>;
>>  			format = "a8r8g8b8";
>> +
>> +			status = "disabled";
> 
> This should be rather removed. What is the idea behind keeping disabled
> node?

Ideally should be removed, yes. A disabled property was added so that if
required, it can be enabled downstream simply by a patch which removes 
it.

And I also understand that upstream doesn't care what's happening 
downstream.
To upstream, it is effectively a dead node. So I'll remove it.

> 
> 
> Best regards,
> Krzysztof