Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
.../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -52,6 +52,12 @@ properties:
- samsung,exynosautov9-sysreg
- const: syscon
deprecated: true
+ - items:
+ - enum:
+ - samsung,exynos7870-cam-sysreg
+ - samsung,exynos7870-disp-sysreg
+ - const: samsung,exynos7870-sysreg
+ - const: syscon
- items:
- enum:
- samsung,exynos850-cmgp-sysreg
--
2.49.0On 12/06/2025 17:23, Kaustabh Chakraborty wrote: > Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are > added, used for the SoC MIPI PHY's CSIS and DSIM blocks. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -52,6 +52,12 @@ properties: > - samsung,exynosautov9-sysreg > - const: syscon > deprecated: true > + - items: > + - enum: > + - samsung,exynos7870-cam-sysreg > + - samsung,exynos7870-disp-sysreg > + - const: samsung,exynos7870-sysreg Drop. These are not really compatible or your commit msg is incomplete. Don't use deprecated syntax and backwards compatible solutions for new hardware. Best regards, Krzysztof
On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -52,6 +52,12 @@ properties:
>> - samsung,exynosautov9-sysreg
>> - const: syscon
>> deprecated: true
>> + - items:
>> + - enum:
>> + - samsung,exynos7870-cam-sysreg
>> + - samsung,exynos7870-disp-sysreg
>> + - const: samsung,exynos7870-sysreg
>
>
> Drop. These are not really compatible or your commit msg is incomplete.
> Don't use deprecated syntax and backwards compatible solutions for new
> hardware.
Are you sure? The deprecated one is actually the item above. From what I
understand, those are generic sysregs and don't mention their functions.
- items:
- enum:
- samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- const: syscon
deprecated: true
>
> Best regards,
> Krzysztof
On 18/06/2025 16:32, Kaustabh Chakraborty wrote: > On 2025-06-18 09:46, Krzysztof Kozlowski wrote: >> On 12/06/2025 17:23, Kaustabh Chakraborty wrote: >>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are >>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks. >>> >>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>> --- >>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644 >>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>> @@ -52,6 +52,12 @@ properties: >>> - samsung,exynosautov9-sysreg >>> - const: syscon >>> deprecated: true >>> + - items: >>> + - enum: >>> + - samsung,exynos7870-cam-sysreg >>> + - samsung,exynos7870-disp-sysreg >>> + - const: samsung,exynos7870-sysreg >> >> >> Drop. These are not really compatible or your commit msg is incomplete. >> Don't use deprecated syntax and backwards compatible solutions for new >> hardware. > > Are you sure? The deprecated one is actually the item above. From what I Yes. Think why were they added. > understand, those are generic sysregs and don't mention their functions. And what is a generic sysreg? Best regards, Krzysztof
On 2025-06-18 14:37, Krzysztof Kozlowski wrote: > On 18/06/2025 16:32, Kaustabh Chakraborty wrote: >> On 2025-06-18 09:46, Krzysztof Kozlowski wrote: >>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote: >>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs >>>> are >>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks. >>>> >>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>> --- >>>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>> | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>> index >>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 >>>> 100644 >>>> --- >>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>> +++ >>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>> @@ -52,6 +52,12 @@ properties: >>>> - samsung,exynosautov9-sysreg >>>> - const: syscon >>>> deprecated: true >>>> + - items: >>>> + - enum: >>>> + - samsung,exynos7870-cam-sysreg >>>> + - samsung,exynos7870-disp-sysreg >>>> + - const: samsung,exynos7870-sysreg >>> >>> >>> Drop. These are not really compatible or your commit msg is >>> incomplete. >>> Don't use deprecated syntax and backwards compatible solutions for >>> new >>> hardware. >> >> Are you sure? The deprecated one is actually the item above. From what >> I > > Yes. Think why were they added. > >> understand, those are generic sysregs and don't mention their >> functions. > > And what is a generic sysreg? What I meant is, usually compatibles go like this (in order): "samsung,exynos<soc>-<function>-sysreg", "samsung,exynos<soc>-sysreg", "syscon" But the deprecated item had its compatibles like this: "samsung,exynos<soc>-sysreg", "syscon" That is what I meant by "generic". It doesn't mention <function>. And my additions adhere to the former. So does [1], [2], and [3]. None are deprecated. [1] https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L40 [2] https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L55 [3] https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L61 > > Best regards, > Krzysztof
On 18/06/2025 16:49, Kaustabh Chakraborty wrote: > On 2025-06-18 14:37, Krzysztof Kozlowski wrote: >> On 18/06/2025 16:32, Kaustabh Chakraborty wrote: >>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote: >>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote: >>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs >>>>> are >>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks. >>>>> >>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>>> --- >>>>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> index >>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 >>>>> 100644 >>>>> --- >>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> +++ >>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> @@ -52,6 +52,12 @@ properties: >>>>> - samsung,exynosautov9-sysreg >>>>> - const: syscon >>>>> deprecated: true >>>>> + - items: >>>>> + - enum: >>>>> + - samsung,exynos7870-cam-sysreg >>>>> + - samsung,exynos7870-disp-sysreg >>>>> + - const: samsung,exynos7870-sysreg >>>> >>>> >>>> Drop. These are not really compatible or your commit msg is >>>> incomplete. >>>> Don't use deprecated syntax and backwards compatible solutions for >>>> new >>>> hardware. >>> >>> Are you sure? The deprecated one is actually the item above. From what >>> I >> >> Yes. Think why were they added. >> >>> understand, those are generic sysregs and don't mention their >>> functions. >> >> And what is a generic sysreg? > > What I meant is, usually compatibles go like this (in order): No, they don't. So you checked why they were added? Best regards, Krzysztof
On 2025-06-18 15:40, Krzysztof Kozlowski wrote: > On 18/06/2025 16:49, Kaustabh Chakraborty wrote: >> On 2025-06-18 14:37, Krzysztof Kozlowski wrote: >>> On 18/06/2025 16:32, Kaustabh Chakraborty wrote: >>>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote: >>>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote: >>>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs >>>>>> are >>>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks. >>>>>> >>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>>>>> --- >>>>>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>>> | 6 ++++++ >>>>>> 1 file changed, 6 insertions(+) >>>>>> >>>>>> diff --git >>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>>> index >>>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 >>>>>> 100644 >>>>>> --- >>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>>> +++ >>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>>> @@ -52,6 +52,12 @@ properties: >>>>>> - samsung,exynosautov9-sysreg >>>>>> - const: syscon >>>>>> deprecated: true >>>>>> + - items: >>>>>> + - enum: >>>>>> + - samsung,exynos7870-cam-sysreg >>>>>> + - samsung,exynos7870-disp-sysreg >>>>>> + - const: samsung,exynos7870-sysreg >>>>> >>>>> >>>>> Drop. These are not really compatible or your commit msg is >>>>> incomplete. >>>>> Don't use deprecated syntax and backwards compatible solutions for >>>>> new >>>>> hardware. >>>> >>>> Are you sure? The deprecated one is actually the item above. From >>>> what >>>> I >>> >>> Yes. Think why were they added. >>> >>>> understand, those are generic sysregs and don't mention their >>>> functions. >>> >>> And what is a generic sysreg? >> >> What I meant is, usually compatibles go like this (in order): > > No, they don't. So you checked why they were added? Checked it, understood. It's meant to be: "samsung,exynos<soc>-<function>-sysreg", "syscon" > > Best regards, > Krzysztof
© 2016 - 2025 Red Hat, Inc.