Drop default ARCH_APPLE from Kconfig and use defconfig instead

[PATCH 07/11] iommu/apple-dart: Drop default ARCH_APPLE in Kconfig

Posted by Sven Peter 3 months, 4 weeks ago

When the first driver for Apple Silicon was upstreamed we accidentally
included `default ARCH_APPLE` in its Kconfig which then spread to almost
every subsequent driver. As soon as ARCH_APPLE is set to y this will
pull in many drivers as built-ins which is not what we want.
Thus, drop `default ARCH_APPLE` from Kconfig.

Signed-off-by: Sven Peter <sven@kernel.org>
---
 drivers/iommu/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index 0a33d995d15dd759eb47705c00b411f1157b408a..91d0c871acc418ac5fede4f177ce3af97aef5560 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -305,7 +305,6 @@ config APPLE_DART
 	depends on !GENERIC_ATOMIC64	# for IOMMU_IO_PGTABLE_DART
 	select IOMMU_API
 	select IOMMU_IO_PGTABLE_DART
-	default ARCH_APPLE
 	help
 	  Support for Apple DART (Device Address Resolution Table) IOMMUs
 	  found in Apple ARM SoCs like the M1.

-- 
2.34.1

Re: [PATCH 07/11] iommu/apple-dart: Drop default ARCH_APPLE in Kconfig

Posted by Joerg Roedel 3 months, 2 weeks ago

On Thu, Jun 12, 2025 at 09:11:31PM +0000, Sven Peter wrote:
>  drivers/iommu/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks Sven.

Re: [PATCH 07/11] iommu/apple-dart: Drop default ARCH_APPLE in Kconfig

Posted by Robin Murphy 3 months, 4 weeks ago

On 2025-06-12 10:11 pm, Sven Peter wrote:
> When the first driver for Apple Silicon was upstreamed we accidentally
> included `default ARCH_APPLE` in its Kconfig which then spread to almost
> every subsequent driver. As soon as ARCH_APPLE is set to y this will
> pull in many drivers as built-ins which is not what we want.
> Thus, drop `default ARCH_APPLE` from Kconfig.

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Sven Peter <sven@kernel.org>
> ---
>   drivers/iommu/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 0a33d995d15dd759eb47705c00b411f1157b408a..91d0c871acc418ac5fede4f177ce3af97aef5560 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -305,7 +305,6 @@ config APPLE_DART
>   	depends on !GENERIC_ATOMIC64	# for IOMMU_IO_PGTABLE_DART
>   	select IOMMU_API
>   	select IOMMU_IO_PGTABLE_DART
> -	default ARCH_APPLE
>   	help
>   	  Support for Apple DART (Device Address Resolution Table) IOMMUs
>   	  found in Apple ARM SoCs like the M1.
>