1. Patchew
  2. linux
  3. [PATCH v2 0/3] arm64: dts: Add support for Ultratronik i.MX8MP Ultra-MACH SBC
  4. View patch

[PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC

Goran Rađenović posted 3 patches 4 months ago
There is a newer version of this series
[PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Goran Rađenović 4 months ago 
Document the Ultratronik Ultra-MACH SBC, based on the NXP i.MX8MP SoC.

This board is manufactured by Ultratronik GmbH and uses the compatible
string "ux,imx8mp-ultra-mach-sbc".

Signed-off-by: Goran Rađenović <goran.radni@gmail.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index d3b5e6923e41..132a6f39b59a 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1232,6 +1232,12 @@ properties:
           - const: tq,imx8mp-tqma8mpql            # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM
           - const: fsl,imx8mp
 
+      - description: Ultratronik SBC i.MX8MP based boards
+        items:
+          - enum:
+              - const: ultratronik,imx8mp-ultra-mach-sbc
+              - const: fsl,imx8mp
+
       - description: Variscite VAR-SOM-MX8M Plus based boards
         items:
           - const: variscite,var-som-mx8mp-symphony
-- 
2.43.0
Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Krzysztof Kozlowski 4 months ago 
On Wed, Jun 11, 2025 at 01:30:37PM GMT, Goran Rađenović wrote:
> Document the Ultratronik Ultra-MACH SBC, based on the NXP i.MX8MP SoC.
> 
> This board is manufactured by Ultratronik GmbH and uses the compatible
> string "ux,imx8mp-ultra-mach-sbc".
> 
> Signed-off-by: Goran Rađenović <goran.radni@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index d3b5e6923e41..132a6f39b59a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1232,6 +1232,12 @@ properties:
>            - const: tq,imx8mp-tqma8mpql            # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM
>            - const: fsl,imx8mp
>  
> +      - description: Ultratronik SBC i.MX8MP based boards
> +        items:
> +          - enum:

Nothing improved... got actually worse, because you never tested it.

  ^
  |
Look here. This is '+' means you added it. My previous comment was that
it should be part of previous enum. If you add enum, then it is not part
of previous, right?

Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Goran Radenovic 4 months ago 
Hi Krzysztof,

Thanks for the feedback, and you're absolutely right — I made a mistake 
here.

That said, I’m still a bit confused by your earlier comment:

     "That's just part of the standard/first enum."

I’m introducing a new board from a new manufacturer, so I expected to 
add a new enum block — similar to how it's done for other vendor entries 
in the same file. I ran dt_binding_check, and it passed without errors 
for this structure.

Could you clarify which “standard/first enum” you were referring to? 
Should all i.MX8MP-based boards share a single enum block, regardless of 
vendor?

Thanks again for your guidance.

Best regards,
Goran

Krzysztof Kozlowski wrote:
> On Wed, Jun 11, 2025 at 01:30:37PM GMT, Goran Rađenović wrote:
>> Document the Ultratronik Ultra-MACH SBC, based on the NXP i.MX8MP SoC.
>>
>> This board is manufactured by Ultratronik GmbH and uses the compatible
>> string "ux,imx8mp-ultra-mach-sbc".
>>
>> Signed-off-by: Goran Rađenović <goran.radni@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index d3b5e6923e41..132a6f39b59a 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1232,6 +1232,12 @@ properties:
>>             - const: tq,imx8mp-tqma8mpql            # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM
>>             - const: fsl,imx8mp
>>   
>> +      - description: Ultratronik SBC i.MX8MP based boards
>> +        items:
>> +          - enum:
> 
> Nothing improved... got actually worse, because you never tested it.
> 
>    ^
>    |
> Look here. This is '+' means you added it. My previous comment was that
> it should be part of previous enum. If you add enum, then it is not part
> of previous, right?
> 
> Best regards,
> Krzysztof
>
Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Krzysztof Kozlowski 4 months ago 
On 12/06/2025 12:09, Goran Radenovic wrote:
> Hi Krzysztof,
> 
> Thanks for the feedback, and you're absolutely right — I made a mistake 
> here.
> 
> That said, I’m still a bit confused by your earlier comment:
> 
>      "That's just part of the standard/first enum."
> 
> I’m introducing a new board from a new manufacturer, so I expected to 
> add a new enum block — similar to how it's done for other vendor entries 

No, you are expected to add to existing enum.

> in the same file. I ran dt_binding_check, and it passed without errors 
> for this structure.

Not possible. The syntax is clearly wrong, so there is no way it passed
any tests. And Rob's report is a proof of that.

> 
> Could you clarify which “standard/first enum” you were referring to? 
> Should all i.MX8MP-based boards share a single enum block, regardless of 
> vendor?

Don't they? Look around in this file.

> 
> Thanks again for your guidance.

Don't top post but reply inline.

Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Goran Radenovic 3 months, 3 weeks ago 

Krzysztof Kozlowski wrote:
> On 12/06/2025 12:09, Goran Radenovic wrote:
>> Hi Krzysztof,
>>
>> Thanks for the feedback, and you're absolutely right — I made a mistake
>> here.
>>
>> That said, I’m still a bit confused by your earlier comment:
>>
>>       "That's just part of the standard/first enum."
>>
>> I’m introducing a new board from a new manufacturer, so I expected to
>> add a new enum block — similar to how it's done for other vendor entries
> 
> No, you are expected to add to existing enum.

Very well, I'll add the entry to the existing `description: i.MX8MP 
based Boards` block.

> 
>> in the same file. I ran dt_binding_check, and it passed without errors
>> for this structure.
> 
> Not possible. The syntax is clearly wrong, so there is no way it passed
> any tests. And Rob's report is a proof of that.
> 

You are right for v2. I was referring to v1. Sorry for the confusion.

>>
>> Could you clarify which “standard/first enum” you were referring to?
>> Should all i.MX8MP-based boards share a single enum block, regardless of
>> vendor?
> 
> Don't they? Look around in this file.
> 

I did, and I've learned something.

>>
>> Thanks again for your guidance.
> 
> Don't top post but reply inline.
> 

Ok, thank you for the correction.

> Best regards,
> Krzysztof


Best regards
Goran
Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC
Posted by Rob Herring (Arm) 4 months ago 
On Wed, 11 Jun 2025 13:30:37 +0200, Goran Rađenović wrote:
> Document the Ultratronik Ultra-MACH SBC, based on the NXP i.MX8MP SoC.
> 
> This board is manufactured by Ultratronik GmbH and uses the compatible
> string "ux,imx8mp-ultra-mach-sbc".
> 
> Signed-off-by: Goran Rađenović <goran.radni@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/fsl.yaml: properties:compatible:oneOf:130:items:0:enum: 'oneOf' conditional failed, one must be fixed:
	{'const': 'ultratronik,imx8mp-ultra-mach-sbc'} is not of type 'integer'
	{'const': 'ultratronik,imx8mp-ultra-mach-sbc'} is not of type 'string'
	{'const': 'fsl,imx8mp'} is not of type 'integer'
	{'const': 'fsl,imx8mp'} is not of type 'string'
	hint: "enum" must be an array of either integers or strings
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/fsl.yaml: properties:compatible:oneOf:130:items:0:enum:0: {'const': 'ultratronik,imx8mp-ultra-mach-sbc'} is not of type 'string'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/fsl.yaml: properties:compatible:oneOf:130:items:0:enum:1: {'const': 'fsl,imx8mp'} is not of type 'string'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250611113039.304742-3-goran.radni@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.