drivers/memory/omap-gpmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
irq_domain_create_simple() takes fwnode as the first argument. It can be
extracted from the struct device using dev_fwnode() helper instead of
using of_node with of_fwnode_handle().
So use the dev_fwnode() helper.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-omap@vger.kernel.org
---
drivers/memory/omap-gpmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 9c96eed00194..d9e13c1f9b13 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -1455,8 +1455,8 @@ static int gpmc_setup_irq(struct gpmc_device *gpmc)
gpmc->irq_chip.irq_unmask = gpmc_irq_unmask;
gpmc->irq_chip.irq_set_type = gpmc_irq_set_type;
- gpmc_irq_domain = irq_domain_create_linear(of_fwnode_handle(gpmc->dev->of_node),
- gpmc->nirqs, &gpmc_irq_domain_ops, gpmc);
+ gpmc_irq_domain = irq_domain_create_linear(dev_fwnode(gpmc->dev), gpmc->nirqs,
+ &gpmc_irq_domain_ops, gpmc);
if (!gpmc_irq_domain) {
dev_err(gpmc->dev, "IRQ domain add failed\n");
return -ENODEV;
--
2.49.0
On Wed, 11 Jun 2025 12:43:40 +0200, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > > [...] Applied, thanks! [1/1] memory: Use dev_fwnode() https://git.kernel.org/krzk/linux-mem-ctrl/c/a0be20055d41028a121a5acc140e17c73d7541c5 Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On 11/06/2025 12:43, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Roger Quadros <rogerq@kernel.org> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: linux-omap@vger.kernel.org > --- Please send patches standard way, so without fake in-reply-to. b4 shazam on entire patchset (because this is not a continuation - see subject prefix) grabs entirely wrong patch: ----------------- Grabbing thread from lore.kernel.org/all/20250611104348.192092-12-jirislaby@kernel.org/t.mbox.gz Breaking thread to remove parents of 20250611104348.192092-12-jirislaby@kernel.org Checking for newer revisions Grabbing search results from lore.kernel.org Added from v2: 1 patches Analyzing 10 messages in the thread Analyzing 19 code-review messages Will use the latest revision: v2 You can pick other revisions using the -vN flag Checking attestation on all messages, may take a moment... --- ✓ [PATCH v2] iio: adc: stm32-adc: Use dev_fwnode() + Link: https://lore.kernel.org/r/20250612084627.217341-1-jirislaby@kernel.org ----------------- Applying single patch also fails: ----------------- Grabbing thread from lore.kernel.org/all/20250611104348.192092-12-jirislaby@kernel.org/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Added from v2: 1 patches Analyzing 10 messages in the thread Analyzing 19 code-review messages Will use the latest revision: v2 You can pick other revisions using the -vN flag Specified msgid is not present in the series, cannot cherrypick ----------------- Best regards, Krzysztof
On 12/06/2025 13:34, Krzysztof Kozlowski wrote: > On 11/06/2025 12:43, Jiri Slaby (SUSE) wrote: >> irq_domain_create_simple() takes fwnode as the first argument. It can be >> extracted from the struct device using dev_fwnode() helper instead of >> using of_node with of_fwnode_handle(). >> >> So use the dev_fwnode() helper. >> >> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> >> Cc: Roger Quadros <rogerq@kernel.org> >> Cc: Tony Lindgren <tony@atomide.com> >> Cc: Krzysztof Kozlowski <krzk@kernel.org> >> Cc: linux-omap@vger.kernel.org >> --- > Please send patches standard way, so without fake in-reply-to. b4 shazam > on entire patchset (because this is not a continuation - see subject > prefix) grabs entirely wrong patch: > > ----------------- > Grabbing thread from > lore.kernel.org/all/20250611104348.192092-12-jirislaby@kernel.org/t.mbox.gz > Breaking thread to remove parents of > 20250611104348.192092-12-jirislaby@kernel.org > Checking for newer revisions > Grabbing search results from lore.kernel.org > Added from v2: 1 patches > Analyzing 10 messages in the thread > Analyzing 19 code-review messages > Will use the latest revision: v2 > You can pick other revisions using the -vN flag > Checking attestation on all messages, may take a moment... > --- > ✓ [PATCH v2] iio: adc: stm32-adc: Use dev_fwnode() > + Link: > https://lore.kernel.org/r/20250612084627.217341-1-jirislaby@kernel.org > ----------------- > > Applying single patch also fails: > > > ----------------- > Grabbing thread from > lore.kernel.org/all/20250611104348.192092-12-jirislaby@kernel.org/t.mbox.gz > Checking for newer revisions > Grabbing search results from lore.kernel.org > Added from v2: 1 patches > Analyzing 10 messages in the thread > Analyzing 19 code-review messages > Will use the latest revision: v2 > You can pick other revisions using the -vN flag > Specified msgid is not present in the series, cannot cherrypick > ----------------- ok, -v1 helped, but this entire dance could be avoided if you sent it standard way, without confusing threading and attaching on patch to something else. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.