1. Patchew
  2. linux
  3. [PATCH v3 0/4] riscv: sophgo: cv18xx: Add reset generator support
  4. View patch

[PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support

Inochi Amaoto posted 4 patches 4 months ago
There is a newer version of this series
[PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Inochi Amaoto 4 months ago 
Add bindings for the reset generator on the SOPHGO CV1800B
RISC-V SoC.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
index 1d1b84575960..bd8dfa998939 100644
--- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
@@ -17,6 +17,7 @@ properties:
               - sophgo,sg2044-reset
           - const: sophgo,sg2042-reset
       - const: sophgo,sg2042-reset
+      - const: sophgo,cv1800b-reset
 
   reg:
     maxItems: 1
-- 
2.49.0
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Krzysztof Kozlowski 4 months ago 
On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
> Add bindings for the reset generator on the SOPHGO CV1800B
> RISC-V SoC.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> index 1d1b84575960..bd8dfa998939 100644
> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> @@ -17,6 +17,7 @@ properties:
>                - sophgo,sg2044-reset
>            - const: sophgo,sg2042-reset
>        - const: sophgo,sg2042-reset
> +      - const: sophgo,cv1800b-reset

Keep alphabetical order. That's enum with previous entry, btw.

Best regards,
Krzysztof
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Inochi Amaoto 4 months ago 
On Wed, Jun 11, 2025 at 10:19:49AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
> > Add bindings for the reset generator on the SOPHGO CV1800B
> > RISC-V SoC.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > index 1d1b84575960..bd8dfa998939 100644
> > --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > @@ -17,6 +17,7 @@ properties:
> >                - sophgo,sg2044-reset
> >            - const: sophgo,sg2042-reset
> >        - const: sophgo,sg2042-reset
> > +      - const: sophgo,cv1800b-reset
> 
> Keep alphabetical order. That's enum with previous entry, btw.
> 

There is a small question for this: should I move this before the entry
"const: sophgo,sg2042-reset", or before the first item entry?

Regards,
Inochi
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Krzysztof Kozlowski 4 months ago 
On 11/06/2025 10:29, Inochi Amaoto wrote:
> On Wed, Jun 11, 2025 at 10:19:49AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
>>> Add bindings for the reset generator on the SOPHGO CV1800B
>>> RISC-V SoC.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>>  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> index 1d1b84575960..bd8dfa998939 100644
>>> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> @@ -17,6 +17,7 @@ properties:
>>>                - sophgo,sg2044-reset
>>>            - const: sophgo,sg2042-reset
>>>        - const: sophgo,sg2042-reset
>>> +      - const: sophgo,cv1800b-reset
>>
>> Keep alphabetical order. That's enum with previous entry, btw.
>>
> 
> There is a small question for this: should I move this before the entry
> "const: sophgo,sg2042-reset", or before the first item entry?
It does not matter where you place the enum. There is no convention for
that.

Best regards,
Krzysztof
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Inochi Amaoto 4 months ago 
On Wed, Jun 11, 2025 at 11:09:50AM +0200, Krzysztof Kozlowski wrote:
> On 11/06/2025 10:29, Inochi Amaoto wrote:
> > On Wed, Jun 11, 2025 at 10:19:49AM +0200, Krzysztof Kozlowski wrote:
> >> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
> >>> Add bindings for the reset generator on the SOPHGO CV1800B
> >>> RISC-V SoC.
> >>>
> >>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> >>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> >>> ---
> >>>  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >>> index 1d1b84575960..bd8dfa998939 100644
> >>> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >>> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >>> @@ -17,6 +17,7 @@ properties:
> >>>                - sophgo,sg2044-reset
> >>>            - const: sophgo,sg2042-reset
> >>>        - const: sophgo,sg2042-reset
> >>> +      - const: sophgo,cv1800b-reset
> >>
> >> Keep alphabetical order. That's enum with previous entry, btw.
> >>
> > 
> > There is a small question for this: should I move this before the entry
> > "const: sophgo,sg2042-reset", or before the first item entry?
> It does not matter where you place the enum. There is no convention for
> that.
> 

Thanks. I will fix it

Regards,
Inochi
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Krzysztof Kozlowski 4 months ago 
On 11/06/2025 10:19, Krzysztof Kozlowski wrote:
> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
>> Add bindings for the reset generator on the SOPHGO CV1800B
>> RISC-V SoC.
>>
>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>>  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>> index 1d1b84575960..bd8dfa998939 100644
>> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>> @@ -17,6 +17,7 @@ properties:
>>                - sophgo,sg2044-reset
>>            - const: sophgo,sg2042-reset
>>        - const: sophgo,sg2042-reset
>> +      - const: sophgo,cv1800b-reset
> 
> Keep alphabetical order. That's enum with previous entry, btw.
> 

Heh, it was an enum when this was acked.

Best regards,
Krzysztof
Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Posted by Inochi Amaoto 4 months ago 
On Wed, Jun 11, 2025 at 10:21:07AM +0200, Krzysztof Kozlowski wrote:
> On 11/06/2025 10:19, Krzysztof Kozlowski wrote:
> > On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
> >> Add bindings for the reset generator on the SOPHGO CV1800B
> >> RISC-V SoC.
> >>
> >> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> >> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> >> ---
> >>  Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >> index 1d1b84575960..bd8dfa998939 100644
> >> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> >> @@ -17,6 +17,7 @@ properties:
> >>                - sophgo,sg2044-reset
> >>            - const: sophgo,sg2042-reset
> >>        - const: sophgo,sg2042-reset
> >> +      - const: sophgo,cv1800b-reset
> > 
> > Keep alphabetical order. That's enum with previous entry, btw.
> > 
> 
> Heh, it was an enum when this was acked.
> 

It seems that I have made a mistake when rebase. I will fix this in
the next version. Thanks for reminder.

Regards,
Inochi

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.