[PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

Michal Luczaj posted 3 patches 4 months ago
tools/testing/vsock/util.c       | 80 ++++++++++++++++++++++++++++++++--
tools/testing/vsock/util.h       | 30 +++++++++++++
tools/testing/vsock/vsock_test.c | 93 ++++++++++++++++++++++++++++++++--------
3 files changed, 181 insertions(+), 22 deletions(-)
[PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test
Posted by Michal Luczaj 4 months ago
Increase the coverage of a test implemented in commit 301a62dfb0d0
("vsock/test: Add test for UAF due to socket unbinding"). Take this
opportunity to factor out some utility code, drop a redundant sync between
client and server, and introduce a /proc/kallsyms harvesting logic for
auto-detecting registered vsock transports.

Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
Changes in v3:
- Drop "RFC" prefix, rebase, amend commit logs
- get_transports(): don't look for a symbol that was already found
- Expand testcase comments, clean up the code [Stefano]
- Streamline `enum transport` and `transport_ksyms` [Stefano]
- Move KALLSYMS_* defines from utils.h to utils.c [Stefano]
- Link to v2: https://lore.kernel.org/r/20250528-vsock-test-inc-cov-v2-0-8f655b40d57c@rbox.co

Changes in v2:
- Speed up: don't bother checking EINTR or respecting timeout on connect()s
- Introduce get_transports(), warn on unsupported setup [Stefano]
- Comment the code, drop the sync, introduce vsock_bind_try() [Stefano]
- Link to v1: https://lore.kernel.org/r/20250523-vsock-test-inc-cov-v1-1-fa3507941bbd@rbox.co

---
Michal Luczaj (3):
      vsock/test: Introduce vsock_bind_try() helper
      vsock/test: Introduce get_transports()
      vsock/test: Cover more CIDs in transport_uaf test

 tools/testing/vsock/util.c       | 80 ++++++++++++++++++++++++++++++++--
 tools/testing/vsock/util.h       | 30 +++++++++++++
 tools/testing/vsock/vsock_test.c | 93 ++++++++++++++++++++++++++++++++--------
 3 files changed, 181 insertions(+), 22 deletions(-)
---
base-commit: 0097c4195b1d0ca57d15979626c769c74747b5a0
change-id: 20250326-vsock-test-inc-cov-b823822bdb78

Best regards,
-- 
Michal Luczaj <mhal@rbox.co>
Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test
Posted by Jakub Kicinski 3 months, 3 weeks ago
On Wed, 11 Jun 2025 21:56:49 +0200 Michal Luczaj wrote:
> Increase the coverage of a test implemented in commit 301a62dfb0d0
> ("vsock/test: Add test for UAF due to socket unbinding"). Take this
> opportunity to factor out some utility code, drop a redundant sync between
> client and server, and introduce a /proc/kallsyms harvesting logic for
> auto-detecting registered vsock transports.

Hi Stefano! Sorry to ping, are these on your radar?
I'm wondering if the delay is because of devconf.cz or you consider 
the Suggested-by tags a strong enough indication of support :)
Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test
Posted by Stefano Garzarella 3 months, 3 weeks ago
On Mon, Jun 16, 2025 at 02:57:29PM -0700, Jakub Kicinski wrote:
>On Wed, 11 Jun 2025 21:56:49 +0200 Michal Luczaj wrote:
>> Increase the coverage of a test implemented in commit 301a62dfb0d0
>> ("vsock/test: Add test for UAF due to socket unbinding"). Take this
>> opportunity to factor out some utility code, drop a redundant sync between
>> client and server, and introduce a /proc/kallsyms harvesting logic for
>> auto-detecting registered vsock transports.
>
>Hi Stefano! Sorry to ping, are these on your radar?
>I'm wondering if the delay is because of devconf.cz or you consider
>the Suggested-by tags a strong enough indication of support :)
>

Yeah, it's because devconf.cz. I'm going to review today, thanks for the 
reminder :-)

Stefano