[PATCH 0/4] media: tc358743: Additional link freq, and better validation

Dave Stevenson posted 4 patches 4 months ago
drivers/media/i2c/tc358743.c | 134 ++++++++++++++++++++++++++++---------------
1 file changed, 87 insertions(+), 47 deletions(-)
[PATCH 0/4] media: tc358743: Additional link freq, and better validation
Posted by Dave Stevenson 4 months ago
I've had these patches on our Raspberry Pi downstream kernel since
I tried upstreaming them back in 2017 [1].
Maxime's asked me to repost them as he's trying to use tc358743 with
mainline in RGB mode[2], and is hitting exactly the problems I had
written them to solve.

The issue from that series of get_mbus_config passing the number of
active data lanes has been resolved.

With regard updating the FIFO trigger level, from the previous
discussions[3]:
- Cisco's use doesn't use OF and therefore is unaffected.
- Philipp's original use case was only 720p60 and 1080p60 UYVY at
  594Mbps.
Both those modes still work with the updated trigger level, but
I'm happy to revise and only use the new trigger level with the
972Mbps data rate if that is deemed necessary.

The final two patches are new but relatively trivial.
The first makes probe fails if the hardware isn't present, and the
second reports the right colorspace for the format.

Hopefully that all makes sense.

  Dave

[1] https://lore.kernel.org/linux-media/cover.1505826082.git.dave.stevenson@raspberrypi.org/
[2] https://lore.kernel.org/linux-media/20250606-roaring-blue-bat-a8b2aa@houat/
[3] https://www.spinics.net/lists/linux-media/msg116360.html

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
Dave Stevenson (4):
      media: tc358743: Add support for 972Mbit/s link freq
      media: tc358743: Increase FIFO trigger level to 374
      media: tc358743: Check I2C succeeded during probe
      media: tc358743: Return an appropriate colorspace from tc358743_set_fmt

 drivers/media/i2c/tc358743.c | 134 ++++++++++++++++++++++++++++---------------
 1 file changed, 87 insertions(+), 47 deletions(-)
---
base-commit: 8d441742cb6a1f1cf1d8f2c73339af27dddb7cf0
change-id: 20250611-media-tc358743-07de40a814bc

Best regards,
-- 
Dave Stevenson <dave.stevenson@raspberrypi.com>
Re: [PATCH 0/4] media: tc358743: Additional link freq, and better validation
Posted by Maxime Ripard 4 months ago
On Wed, 11 Jun 2025 19:37:12 +0100, Dave Stevenson wrote:
> I've had these patches on our Raspberry Pi downstream kernel since
> I tried upstreaming them back in 2017 [1].
> Maxime's asked me to repost them as he's trying to use tc358743 with
> mainline in RGB mode[2], and is hitting exactly the problems I had
> written them to solve.
> 
> [ ... ]

Tested-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime