Use dev_err_probe() when returning an error in the probe function.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/amplifiers/ada4250.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4250.c
index d20ca410c506226fce7f172632d46b2ebb140a12..40f396ea906950ab79bf72cdb162794e95f76094 100644
--- a/drivers/iio/amplifiers/ada4250.c
+++ b/drivers/iio/amplifiers/ada4250.c
@@ -351,10 +351,8 @@ static int ada4250_probe(struct spi_device *spi)
 	mutex_init(&st->lock);
 
 	ret = ada4250_init(st);
-	if (ret) {
-		dev_err(&spi->dev, "ADA4250 init failed\n");
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n");
 
 	return devm_iio_device_register(&spi->dev, indio_dev);
 }

-- 
2.43.0

On Wed, Jun 11, 2025 at 04:33:05PM -0500, David Lechner wrote:
> Use dev_err_probe() when returning an error in the probe function.

...

>  	mutex_init(&st->lock);

Side note. Switch to devm?

...

>  	ret = ada4250_init(st);

Is this used only in ->probe() stage? If so, please also move to
dev_err_probe() there.

> -	if (ret) {
> -		dev_err(&spi->dev, "ADA4250 init failed\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n");
>  
>  	return devm_iio_device_register(&spi->dev, indio_dev);

-- 
With Best Regards,
Andy Shevchenko

On 6/12/25 8:05 AM, Andy Shevchenko wrote:
> On Wed, Jun 11, 2025 at 04:33:05PM -0500, David Lechner wrote:
>> Use dev_err_probe() when returning an error in the probe function.
> 
> ...
> 
>>  	mutex_init(&st->lock);
> 
> Side note. Switch to devm?

Yup, missed that.

> 
> ...
> 
>>  	ret = ada4250_init(st);
> 
> Is this used only in ->probe() stage? If so, please also move to
> dev_err_probe() there.

After all of the other changes, there was nothing left to convert
to dev_err_probe() there.

> 
>> -	if (ret) {
>> -		dev_err(&spi->dev, "ADA4250 init failed\n");
>> -		return ret;
>> -	}
>> +	if (ret)
>> +		return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n");
>>  
>>  	return devm_iio_device_register(&spi->dev, indio_dev);
>