drm/bridge: it6505: select REGMAP_I2C

[PATCH] drm/bridge: it6505: select REGMAP_I2C

Posted by Chia-I Wu 4 months ago

Fix

  aarch64-linux-gnu-ld: drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_i2c_probe':
  ite-it6505.c:(.text+0x754): undefined reference to `__devm_regmap_init_i2c'

Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index b9e0ca85226a6..a6d6e62071a0e 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -122,6 +122,7 @@ config DRM_ITE_IT6505
 	select EXTCON
 	select CRYPTO
 	select CRYPTO_HASH
+	select REGMAP_I2C
 	help
 	  ITE IT6505 DisplayPort bridge chip driver.
 
-- 
2.50.0.rc0.642.g800a2b2222-goog

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

Posted by Chen-Yu Tsai 1 month, 4 weeks ago

On Tue, 10 Jun 2025 16:58:25 -0700, Chia-I Wu wrote:
> Fix
> 
>   aarch64-linux-gnu-ld: drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_i2c_probe':
>   ite-it6505.c:(.text+0x754): undefined reference to `__devm_regmap_init_i2c'
> 
> 

Applied, thanks!

[1/1] drm/bridge: it6505: select REGMAP_I2C
      commit: 21b137f651cf9d981e22d2c60a2a8105f50a6361

Best regards,
-- 
Chen-Yu Tsai <wenst@chromium.org>

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

Posted by Chen-Yu Tsai 2 months, 2 weeks ago

On Tue, Jun 10, 2025 at 04:58:25PM -0700, Chia-I Wu wrote:
> Fix
> 
>   aarch64-linux-gnu-ld: drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_i2c_probe':
>   ite-it6505.c:(.text+0x754): undefined reference to `__devm_regmap_init_i2c'

Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")

> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

Somehow I botched my previous reply.

> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index b9e0ca85226a6..a6d6e62071a0e 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -122,6 +122,7 @@ config DRM_ITE_IT6505
>  	select EXTCON
>  	select CRYPTO
>  	select CRYPTO_HASH
> +	select REGMAP_I2C
>  	help
>  	  ITE IT6505 DisplayPort bridge chip driver.
>  
> -- 
> 2.50.0.rc0.642.g800a2b2222-goog
>

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

Posted by Chia-I Wu 3 months ago

Can anyone help review this?  It is a trivial build fix.

On Tue, Jun 10, 2025 at 4:58 PM Chia-I Wu <olvaffe@gmail.com> wrote:
>
> Fix
>
>   aarch64-linux-gnu-ld: drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_i2c_probe':
>   ite-it6505.c:(.text+0x754): undefined reference to `__devm_regmap_init_i2c'
>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index b9e0ca85226a6..a6d6e62071a0e 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -122,6 +122,7 @@ config DRM_ITE_IT6505
>         select EXTCON
>         select CRYPTO
>         select CRYPTO_HASH
> +       select REGMAP_I2C
>         help
>           ITE IT6505 DisplayPort bridge chip driver.
>
> --
> 2.50.0.rc0.642.g800a2b2222-goog
>