Fix 'message_priprity' typo to 'message_priority' in big endian
bitfield definition. This typo breaks compilation on big endian
architectures.

Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
Cc: stable@vger.kernel.org # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
---
 include/net/pfcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/pfcp.h b/include/net/pfcp.h
index af14f970b80e1..639553797d3e4 100644
--- a/include/net/pfcp.h
+++ b/include/net/pfcp.h
@@ -45,7 +45,7 @@ struct pfcphdr_session {
 		reserved:4;
 #elif defined(__BIG_ENDIAN_BITFIELD)
 	u8	reserved:4,
-		message_priprity:4;
+		message_priority:4;
 #else
 #error "Please fix <asm/byteorder>"
 #endif
-- 
2.49.0

RubenKelevra <rubenkelevra@gmail.com> writes:

> Fix 'message_priprity' typo to 'message_priority' in big endian
> bitfield definition. This typo breaks compilation on big endian
> architectures.
>
> Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
> Cc: stable@vger.kernel.org # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
> Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
> ---
>  include/net/pfcp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I had the same issue today, happy there's a patch for this.

Reviewed-by: Charalampos Mitrodimas <charmitro@posteo.net>

On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
> > Fix 'message_priprity' typo to 'message_priority' in big endian
> > bitfield definition. This typo breaks compilation on big endian
> > architectures.
> >
> > Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
> > Cc: stable@vger.kernel.org # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
> > Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
>
> I had the same issue today, happy there's a patch for this.

Could y'all share more? What compilation does this break?
The field is never used.

More info about how you found the problem would be useful.
And I believe this can go to net-next, without the CC stable
and without the Fixes tag. Unless my grep is lying to me:

net-next$ git grep message_priority
include/net/pfcp.h:     u8      message_priority:4,
-- 
pw-bot: cr

Hi Jakub,

I hit it while building an out-of-tree module that reads hdr->message_priority.
Cross-compiling for a big-endian target failed for me, because of it.

That’s the only reason for the patch; net-next is fine, no need for stable.

Cheers,
Ruben

On Wed, Jun 11, 2025 at 11:51 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
> > > Fix 'message_priprity' typo to 'message_priority' in big endian
> > > bitfield definition. This typo breaks compilation on big endian
> > > architectures.
> > >
> > > Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Cc: stable@vger.kernel.org # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
> >
> > I had the same issue today, happy there's a patch for this.
>
> Could y'all share more? What compilation does this break?
> The field is never used.
>
> More info about how you found the problem would be useful.
> And I believe this can go to net-next, without the CC stable
> and without the Fixes tag. Unless my grep is lying to me:
>
> net-next$ git grep message_priority
> include/net/pfcp.h:     u8      message_priority:4,
> --
> pw-bot: cr

On Thu, 12 Jun 2025 08:38:20 +0200 Ruben Kelevra wrote:
> I hit it while building an out-of-tree module that reads hdr->message_priority.
> Cross-compiling for a big-endian target failed for me, because of it.
> 
> That’s the only reason for the patch; net-next is fine, no need for stable.

I see, please go ahead and repost with [PATCH net-next], no stable cc
and no fixes tag. Would also be good to mention in the commit message
that it does not currently cause kernel build issues, but is clearly
incorrect.

The field is spelled “message_priprity” in the big-endian bit-field
definition.  Nothing in-tree currently references the member, so the
typo does not break kernel builds, but it is clearly incorrect and
confuses out-of-tree code.

Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>
---
 include/net/pfcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/pfcp.h b/include/net/pfcp.h
index af14f970b80e1..639553797d3e4 100644
--- a/include/net/pfcp.h
+++ b/include/net/pfcp.h
@@ -45,7 +45,7 @@ struct pfcphdr_session {
 		reserved:4;
 #elif defined(__BIG_ENDIAN_BITFIELD)
 	u8	reserved:4,
-		message_priprity:4;
+		message_priority:4;
 #else
 #error "Please fix <asm/byteorder>"
 #endif
-- 
2.49.0