After commit a934a57a42f6 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1") we get the build
warnings with W=1:
drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Fix them.
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index f583924eb16bb..c2d21eecafe79 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -8,6 +8,7 @@
#include <linux/dmaengine.h>
#include <linux/dma-mapping.h>
+#include <linux/export.h>
#include <linux/iio/adc/stm32-dfsdm-adc.h>
#include <linux/iio/backend.h>
#include <linux/iio/buffer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 041dc9ebc0482..47e2d1338e9e6 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -8,6 +8,7 @@
#include <linux/bitfield.h>
#include <linux/clk.h>
+#include <linux/export.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
#include <linux/interrupt.h>
--
2.34.1
On 6/10/25 14:48, Antonio Borneo wrote: > After commit a934a57a42f6 ("scripts/misc-check: check missing #include > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check: > check unnecessary #include <linux/export.h> when W=1") we get the build > warnings with W=1: > > drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > Fix them. > > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> Hi Antonio, You can add my: Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Thanks, Fabrice > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 1 + > drivers/iio/adc/stm32-dfsdm-core.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index f583924eb16bb..c2d21eecafe79 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -8,6 +8,7 @@ > > #include <linux/dmaengine.h> > #include <linux/dma-mapping.h> > +#include <linux/export.h> > #include <linux/iio/adc/stm32-dfsdm-adc.h> > #include <linux/iio/backend.h> > #include <linux/iio/buffer.h> > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 041dc9ebc0482..47e2d1338e9e6 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -8,6 +8,7 @@ > > #include <linux/bitfield.h> > #include <linux/clk.h> > +#include <linux/export.h> > #include <linux/iio/iio.h> > #include <linux/iio/sysfs.h> > #include <linux/interrupt.h>
On Tue, 10 Jun 2025 15:05:16 +0200 Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote: > On 6/10/25 14:48, Antonio Borneo wrote: > > After commit a934a57a42f6 ("scripts/misc-check: check missing #include > > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check: > > check unnecessary #include <linux/export.h> when W=1") we get the build > > warnings with W=1: > > > > drivers/iio/adc/stm32-dfsdm-adc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > drivers/iio/adc/stm32-dfsdm-core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > > > Fix them. > > > > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> > > Hi Antonio, > > You can add my: > Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Applied to the togreg branch of iio.git. Ta. > > Thanks, > Fabrice > > --- > > drivers/iio/adc/stm32-dfsdm-adc.c | 1 + > > drivers/iio/adc/stm32-dfsdm-core.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index f583924eb16bb..c2d21eecafe79 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -8,6 +8,7 @@ > > > > #include <linux/dmaengine.h> > > #include <linux/dma-mapping.h> > > +#include <linux/export.h> > > #include <linux/iio/adc/stm32-dfsdm-adc.h> > > #include <linux/iio/backend.h> > > #include <linux/iio/buffer.h> > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > > index 041dc9ebc0482..47e2d1338e9e6 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-core.c > > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > > @@ -8,6 +8,7 @@ > > > > #include <linux/bitfield.h> > > #include <linux/clk.h> > > +#include <linux/export.h> > > #include <linux/iio/iio.h> > > #include <linux/iio/sysfs.h> > > #include <linux/interrupt.h>
© 2016 - 2025 Red Hat, Inc.