rust/kernel/alloc/kvec.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The implementation of Default is restricted to only work with kmalloc
vectors for no good reason. This means I have to use
mem::replace(&mut my_vec, KVVec::new())
in Rust Binder instead of `mem::take(&mut my_vec)`. Thus, expand the
impl of Default to work with any allocator including kvmalloc.
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
rust/kernel/alloc/kvec.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs
index 1a0dd852a468ccda6ea1b521bc1e7dbc8d7fc79c..606616fc0e592f87264bf905c88ef44e19739c0e 100644
--- a/rust/kernel/alloc/kvec.rs
+++ b/rust/kernel/alloc/kvec.rs
@@ -851,7 +851,7 @@ fn drop(&mut self) {
}
}
-impl<T> Default for KVec<T> {
+impl<T, A: Allocator> Default for Vec<T, A> {
#[inline]
fn default() -> Self {
Self::new()
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250610-vec-default-4b0c54aadebc
Best regards,
--
Alice Ryhl <aliceryhl@google.com>
On 6/10/25 12:31 PM, Alice Ryhl wrote: > The implementation of Default is restricted to only work with kmalloc > vectors for no good reason. This means I have to use > > mem::replace(&mut my_vec, KVVec::new()) > > in Rust Binder instead of `mem::take(&mut my_vec)`. Thus, expand the > impl of Default to work with any allocator including kvmalloc. Applied to alloc-next, thanks!
On Tue Jun 10, 2025 at 12:31 PM CEST, Alice Ryhl wrote: > The implementation of Default is restricted to only work with kmalloc > vectors for no good reason. This means I have to use > > mem::replace(&mut my_vec, KVVec::new()) > > in Rust Binder instead of `mem::take(&mut my_vec)`. Thus, expand the > impl of Default to work with any allocator including kvmalloc. > > Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Benno Lossin <lossin@kernel.org> --- Cheers, Benno > --- > rust/kernel/alloc/kvec.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
© 2016 - 2025 Red Hat, Inc.