[v3] Add CMN PLL clock controller support for IPQ5424

[PATCH v3 0/4] Add CMN PLL clock controller support for IPQ5424

Posted by Luo Jie 4 months ago

The CMN PLL block of IPQ5424 is almost same as that of IPQ9574
which is currently supported by the driver. The only difference
is that the fixed output clocks to NSS and PPE from CMN PLL have
a different clock rate. In IPQ5424, the output clocks are supplied
to NSS at 300 MHZ and to PPE at 375 MHZ.

This patch series extends the CMN PLL driver to support IPQ5424.
It also adds the SoC specific header file to export the CMN PLL
output clock specifiers for IPQ5424. The new table of output
clocks is added for the CMN PLL of IPQ5424, which is acquired
from the device according to the compatible.

Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
Changes in v3:
- Collect review tags for the DT binding and driver patches.
- Rebase onto the latest code to resolve conflicts in the DTS patch.
- Link to v2: https://lore.kernel.org/r/20250411-qcom_ipq5424_cmnpll-v2-0-7252c192e078@quicinc.com

Changes in v2:
- Alphanumeric order for the compatible strings in dtbindings.
- Add the IPQ5424 SoC specific header file to export the clock specifiers.
- Drop the comma of the sentinel entry of the output clock array.
- Add Reviewed-by tag on the DTS patches.
- Link to v1: https://lore.kernel.org/r/20250321-qcom_ipq5424_cmnpll-v1-0-3ea8e5262da4@quicinc.com

---
Luo Jie (4):
dt-bindings: clock: qcom: Add CMN PLL support for IPQ5424 SoC
clk: qcom: cmnpll: Add IPQ5424 SoC support
arm64: dts: ipq5424: Add CMN PLL node
arm64: dts: qcom: Update IPQ5424 xo_board to use fixed factor clock

.../bindings/clock/qcom,ipq9574-cmn-pll.yaml | 1 +
arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 24 +++++++++++++--
arch/arm64/boot/dts/qcom/ipq5424.dtsi | 27 ++++++++++++++++-
drivers/clk/qcom/ipq-cmn-pll.c | 35 ++++++++++++++++++----
include/dt-bindings/clock/qcom,ipq5424-cmn-pll.h | 22 ++++++++++++++
5 files changed, 101 insertions(+), 8 deletions(-)
---
base-commit: b27cc623e01be9de1580eaa913508b237a7a9673
change-id: 20250610-qcom_ipq5424_cmnpll-22b232bb18fd

Best regards,
--
Luo Jie <quic_luoj@quicinc.com>

Re: [PATCH v3 0/4] Add CMN PLL clock controller support for IPQ5424

Posted by Luo Jie 3 months, 2 weeks ago

Hi Bjorn,

I wanted to check on this patch series. All review comments
have been addressed, and there have been no further objections.
Would you consider merging these patches? Thank you for your
time and feedback!

Best Regards,
Jie

On 6/10/2025 6:35 PM, Luo Jie wrote:
> The CMN PLL block of IPQ5424 is almost same as that of IPQ9574
> which is currently supported by the driver. The only difference
> is that the fixed output clocks to NSS and PPE from CMN PLL have
> a different clock rate. In IPQ5424, the output clocks are supplied
> to NSS at 300 MHZ and to PPE at 375 MHZ.
> 
> This patch series extends the CMN PLL driver to support IPQ5424.
> It also adds the SoC specific header file to export the CMN PLL
> output clock specifiers for IPQ5424. The new table of output
> clocks is added for the CMN PLL of IPQ5424, which is acquired
> from the device according to the compatible.
> 
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> ---
> Changes in v3:
> - Collect review tags for the DT binding and driver patches.
> - Rebase onto the latest code to resolve conflicts in the DTS patch.
> - Link to v2: https://lore.kernel.org/r/20250411-qcom_ipq5424_cmnpll-v2-0-7252c192e078@quicinc.com
> 
> Changes in v2:
> - Alphanumeric order for the compatible strings in dtbindings.
> - Add the IPQ5424 SoC specific header file to export the clock specifiers.
> - Drop the comma of the sentinel entry of the output clock array.
> - Add Reviewed-by tag on the DTS patches.
> - Link to v1: https://lore.kernel.org/r/20250321-qcom_ipq5424_cmnpll-v1-0-3ea8e5262da4@quicinc.com
> 
> ---
> Luo Jie (4):
>        dt-bindings: clock: qcom: Add CMN PLL support for IPQ5424 SoC
>        clk: qcom: cmnpll: Add IPQ5424 SoC support
>        arm64: dts: ipq5424: Add CMN PLL node
>        arm64: dts: qcom: Update IPQ5424 xo_board to use fixed factor clock
> 
>   .../bindings/clock/qcom,ipq9574-cmn-pll.yaml       |  1 +
>   arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts        | 24 +++++++++++++--
>   arch/arm64/boot/dts/qcom/ipq5424.dtsi              | 27 ++++++++++++++++-
>   drivers/clk/qcom/ipq-cmn-pll.c                     | 35 ++++++++++++++++++----
>   include/dt-bindings/clock/qcom,ipq5424-cmn-pll.h   | 22 ++++++++++++++
>   5 files changed, 101 insertions(+), 8 deletions(-)
> ---
> base-commit: b27cc623e01be9de1580eaa913508b237a7a9673
> change-id: 20250610-qcom_ipq5424_cmnpll-22b232bb18fd
> 
> Best regards,

Re: (subset) [PATCH v3 0/4] Add CMN PLL clock controller support for IPQ5424

Posted by Bjorn Andersson 2 months, 3 weeks ago

On Tue, 10 Jun 2025 18:35:17 +0800, Luo Jie wrote:
> The CMN PLL block of IPQ5424 is almost same as that of IPQ9574
> which is currently supported by the driver. The only difference
> is that the fixed output clocks to NSS and PPE from CMN PLL have
> a different clock rate. In IPQ5424, the output clocks are supplied
> to NSS at 300 MHZ and to PPE at 375 MHZ.
> 
> This patch series extends the CMN PLL driver to support IPQ5424.
> It also adds the SoC specific header file to export the CMN PLL
> output clock specifiers for IPQ5424. The new table of output
> clocks is added for the CMN PLL of IPQ5424, which is acquired
> from the device according to the compatible.
> 
> [...]

Applied, thanks!

[3/4] arm64: dts: ipq5424: Add CMN PLL node
      commit: 0c8ad32ea8acbcd5959ec21f15c6ea794b957b1a
[4/4] arm64: dts: qcom: Update IPQ5424 xo_board to use fixed factor clock
      commit: 671606d2807550f34e6064f12b227eb489e9cc77

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>