1. Patchew
  2. linux
  3. View series

[PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

Bartosz Golaszewski posted 3 patches 8 months ago 
drivers/input/keyboard/adp5588-keys.c |  9 +++++----
drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
drivers/input/touchscreen/ad7879.c    | 11 +++++++----
3 files changed, 18 insertions(+), 13 deletions(-)
[PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters
Posted by Bartosz Golaszewski 8 months ago 
Never got any further feedback on this series last cycle. Resending for
v6.17.

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. We're in the process of
converting all GPIO drivers to using the new API. This series converts
all the GPIO controllers under drivers/input/.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
      Input: ad7879 - use new GPIO line value setter callbacks
      Input: adp5588 - use new GPIO line value setter callbacks
      Input: adp5589 - use new GPIO line value setter callbacks

 drivers/input/keyboard/adp5588-keys.c |  9 +++++----
 drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
 drivers/input/touchscreen/ad7879.c    | 11 +++++++----
 3 files changed, 18 insertions(+), 13 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250331-gpiochip-set-rv-input-bc12818c5732

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters
Posted by Bartosz Golaszewski 7 months, 2 weeks ago 
On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> Never got any further feedback on this series last cycle. Resending for
> v6.17.
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the GPIO controllers under drivers/input/.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Bartosz Golaszewski (3):
>       Input: ad7879 - use new GPIO line value setter callbacks
>       Input: adp5588 - use new GPIO line value setter callbacks
>       Input: adp5589 - use new GPIO line value setter callbacks
>
>  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
>  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
>  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
>  3 files changed, 18 insertions(+), 13 deletions(-)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>

Dmitry,

Could you please pick these patches up for v6.17? They already missed
the last cycle and we're on track to complete the conversion in the
next one so I'd really appreciate these going upstream in the next
merge window.

Bart
Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters
Posted by Dmitry Torokhov 7 months, 2 weeks ago 
Hi Bartosz,

On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > Never got any further feedback on this series last cycle. Resending for
> > v6.17.
> >
> > struct gpio_chip now has callbacks for setting line values that return
> > an integer, allowing to indicate failures. We're in the process of
> > converting all GPIO drivers to using the new API. This series converts
> > all the GPIO controllers under drivers/input/.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > Bartosz Golaszewski (3):
> >       Input: ad7879 - use new GPIO line value setter callbacks
> >       Input: adp5588 - use new GPIO line value setter callbacks
> >       Input: adp5589 - use new GPIO line value setter callbacks
> >
> >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> >  3 files changed, 18 insertions(+), 13 deletions(-)
> > ---
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> >
> > Best regards,
> > --
> > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> 
> Dmitry,
> 
> Could you please pick these patches up for v6.17? They already missed
> the last cycle and we're on track to complete the conversion in the
> next one so I'd really appreciate these going upstream in the next
> merge window.

My apologies, I was hoping Nuno's conversion of these drivers to MFD
would be accepted and these versions be simply removed...

I acked all 3.

Thanks.

-- 
Dmitry
Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters
Posted by Bartosz Golaszewski 7 months, 2 weeks ago 
On Thu, Jun 26, 2025 at 7:54 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Bartosz,
>
> On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> > On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > Never got any further feedback on this series last cycle. Resending for
> > > v6.17.
> > >
> > > struct gpio_chip now has callbacks for setting line values that return
> > > an integer, allowing to indicate failures. We're in the process of
> > > converting all GPIO drivers to using the new API. This series converts
> > > all the GPIO controllers under drivers/input/.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > > Bartosz Golaszewski (3):
> > >       Input: ad7879 - use new GPIO line value setter callbacks
> > >       Input: adp5588 - use new GPIO line value setter callbacks
> > >       Input: adp5589 - use new GPIO line value setter callbacks
> > >
> > >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> > >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> > >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> > >  3 files changed, 18 insertions(+), 13 deletions(-)
> > > ---
> > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> > >
> > > Best regards,
> > > --
> > > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> >
> > Dmitry,
> >
> > Could you please pick these patches up for v6.17? They already missed
> > the last cycle and we're on track to complete the conversion in the
> > next one so I'd really appreciate these going upstream in the next
> > merge window.
>
> My apologies, I was hoping Nuno's conversion of these drivers to MFD
> would be accepted and these versions be simply removed...
>
> I acked all 3.
>
> Thanks.
>
> --
> Dmitry

Does this mean you prefer me to take them through the GPIO tree? Do
you want an immutable branch?

Bart
Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters
Posted by Dmitry Torokhov 7 months, 2 weeks ago 
On Thu, Jun 26, 2025 at 09:37:08AM +0200, Bartosz Golaszewski wrote:
> On Thu, Jun 26, 2025 at 7:54 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Hi Bartosz,
> >
> > On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> > > On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > Never got any further feedback on this series last cycle. Resending for
> > > > v6.17.
> > > >
> > > > struct gpio_chip now has callbacks for setting line values that return
> > > > an integer, allowing to indicate failures. We're in the process of
> > > > converting all GPIO drivers to using the new API. This series converts
> > > > all the GPIO controllers under drivers/input/.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > > ---
> > > > Bartosz Golaszewski (3):
> > > >       Input: ad7879 - use new GPIO line value setter callbacks
> > > >       Input: adp5588 - use new GPIO line value setter callbacks
> > > >       Input: adp5589 - use new GPIO line value setter callbacks
> > > >
> > > >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> > > >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> > > >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> > > >  3 files changed, 18 insertions(+), 13 deletions(-)
> > > > ---
> > > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> > > >
> > > > Best regards,
> > > > --
> > > > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > >
> > > Dmitry,
> > >
> > > Could you please pick these patches up for v6.17? They already missed
> > > the last cycle and we're on track to complete the conversion in the
> > > next one so I'd really appreciate these going upstream in the next
> > > merge window.
> >
> > My apologies, I was hoping Nuno's conversion of these drivers to MFD
> > would be accepted and these versions be simply removed...
> >
> > I acked all 3.
> >
> > Thanks.
> >
> > --
> > Dmitry
> 
> Does this mean you prefer me to take them through the GPIO tree? Do
> you want an immutable branch?

Ah, my bad, I thought there was dependency on -next for these. I applied
them and sorry for the delay.

Thanks.

-- 
Dmitry

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.