[PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR

Sven Peter posted 1 patch 6 months ago
arch/arm64/boot/dts/apple/spi1-nvram.dtsi | 2 --
1 file changed, 2 deletions(-)
[PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
Posted by Sven Peter 6 months ago
Fix the following warning by dropping #{address,size}-cells from the SPI
NOR node which only has a single child node without reg property:

spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property

Fixes: 3febe9de5ca5 ("arm64: dts: apple: Add SPI NOR nvram partition to all devices")
Signed-off-by: Sven Peter <sven@kernel.org>
---
 arch/arm64/boot/dts/apple/spi1-nvram.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
index 3df2fd3993b52884d7c00b65099c88d830a7a4c3..9740fbf200f0bcd0e7d1b81885fe9d9ff8f04fdc 100644
--- a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
+++ b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
@@ -20,8 +20,6 @@ flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0x0>;
 		spi-max-frequency = <25000000>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 
 		partitions {
 			compatible = "fixed-partitions";

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250530-apple-dts-warnings-8bb373367b54

Best regards,
-- 
Sven Peter <sven@kernel.org>
Re: [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
Posted by Sven Peter 6 months ago
On Tue, 10 Jun 2025 19:19:24 +0000, Sven Peter wrote:
> Fix the following warning by dropping #{address,size}-cells from the SPI
> NOR node which only has a single child node without reg property:
> 
> spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> 
> 

Applied, thanks!

[1/1] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
      commit: 811a909978bf59caa25359e0aca4e30500dcff26

Best regards,
-- 
Sven Peter <sven@kernel.org>
Re: [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
Posted by Janne Grunau 6 months ago
On Tue, Jun 10, 2025 at 07:19:24PM +0000, Sven Peter wrote:
> Fix the following warning by dropping #{address,size}-cells from the SPI
> NOR node which only has a single child node without reg property:
> 
> spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> 
> Fixes: 3febe9de5ca5 ("arm64: dts: apple: Add SPI NOR nvram partition to all devices")
> Signed-off-by: Sven Peter <sven@kernel.org>
> ---
>  arch/arm64/boot/dts/apple/spi1-nvram.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> index 3df2fd3993b52884d7c00b65099c88d830a7a4c3..9740fbf200f0bcd0e7d1b81885fe9d9ff8f04fdc 100644
> --- a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> +++ b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> @@ -20,8 +20,6 @@ flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0x0>;
>  		spi-max-frequency = <25000000>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  
>  		partitions {
>  			compatible = "fixed-partitions";
> 

Reviewed-by: Janne Grunau <j@jannau.net>

Janne