[PATCHv5 0/5] wifi: ath9k: add ahb OF support

Rosen Penev posted 5 patches 6 months, 1 week ago
.../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
.../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
.../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
.../qca/ar9331_openembed_som9331_board.dts    |  4 ++
arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
10 files changed, 84 insertions(+), 41 deletions(-)
[PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Rosen Penev 6 months, 1 week ago
First two commits are small cleanups to make the changes of the third
simpler. The fourth actually adds dts definitions to use ahb.

v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
v3: Use qcom prefix and wifi suffix as in other ath drivers.
v4: fix up dts example in Documentation
v5: move back to using qca prefix. It makes no sense to diverge between
all the other drivers for MIPS based qualcomm devices. qcom as a prefix
is used for Quallcomm's ARM(64) stuff.

Rosen Penev (5):
  wifi: ath9k: ahb: reorder declarations
  wifi: ath9k: ahb: reorder includes
  wifi: ath9k: ahb: replace id_table with of
  dt-bindings: net: wireless: ath9k: add OF bindings
  mips: dts: qca: add wmac support

 .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
 arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
 .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
 arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
 .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
 arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
 .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
 drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
 10 files changed, 84 insertions(+), 41 deletions(-)

-- 
2.49.0
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Jeff Johnson 5 months, 3 weeks ago
On 6/8/2025 8:08 PM, Rosen Penev wrote:
> First two commits are small cleanups to make the changes of the third
> simpler. The fourth actually adds dts definitions to use ahb.
> 
> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
> v3: Use qcom prefix and wifi suffix as in other ath drivers.
> v4: fix up dts example in Documentation
> v5: move back to using qca prefix. It makes no sense to diverge between
> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
> is used for Quallcomm's ARM(64) stuff.
> 
> Rosen Penev (5):
>   wifi: ath9k: ahb: reorder declarations
>   wifi: ath9k: ahb: reorder includes
>   wifi: ath9k: ahb: replace id_table with of
>   dt-bindings: net: wireless: ath9k: add OF bindings
>   mips: dts: qca: add wmac support
> 
>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>  10 files changed, 84 insertions(+), 41 deletions(-)
> 

DT team, should I take this series through my tree?
Toke, Ack?

/jeff
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Krzysztof Kozlowski 5 months, 3 weeks ago
On 20/06/2025 02:33, Jeff Johnson wrote:
> On 6/8/2025 8:08 PM, Rosen Penev wrote:
>> First two commits are small cleanups to make the changes of the third
>> simpler. The fourth actually adds dts definitions to use ahb.
>>
>> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
>> v3: Use qcom prefix and wifi suffix as in other ath drivers.
>> v4: fix up dts example in Documentation
>> v5: move back to using qca prefix. It makes no sense to diverge between
>> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
>> is used for Quallcomm's ARM(64) stuff.
>>
>> Rosen Penev (5):
>>   wifi: ath9k: ahb: reorder declarations
>>   wifi: ath9k: ahb: reorder includes
>>   wifi: ath9k: ahb: replace id_table with of
>>   dt-bindings: net: wireless: ath9k: add OF bindings
>>   mips: dts: qca: add wmac support
>>
>>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>>  10 files changed, 84 insertions(+), 41 deletions(-)
>>
> 
> DT team, should I take this series through my tree?
> Toke, Ack?
No, of course not. The same as you asked some time ago: DTS never, NEVER
goes via driver subsystem tree.

Best regards,
Krzysztof
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Krzysztof Kozlowski 5 months, 3 weeks ago
On 20/06/2025 07:32, Krzysztof Kozlowski wrote:
> On 20/06/2025 02:33, Jeff Johnson wrote:
>> On 6/8/2025 8:08 PM, Rosen Penev wrote:
>>> First two commits are small cleanups to make the changes of the third
>>> simpler. The fourth actually adds dts definitions to use ahb.
>>>
>>> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
>>> v3: Use qcom prefix and wifi suffix as in other ath drivers.
>>> v4: fix up dts example in Documentation
>>> v5: move back to using qca prefix. It makes no sense to diverge between
>>> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
>>> is used for Quallcomm's ARM(64) stuff.
>>>
>>> Rosen Penev (5):
>>>   wifi: ath9k: ahb: reorder declarations
>>>   wifi: ath9k: ahb: reorder includes
>>>   wifi: ath9k: ahb: replace id_table with of
>>>   dt-bindings: net: wireless: ath9k: add OF bindings
>>>   mips: dts: qca: add wmac support
>>>
>>>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>>>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>>>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>>>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>>>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>>>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>>>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>>>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>>>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>>>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>>>  10 files changed, 84 insertions(+), 41 deletions(-)
>>>
>>
>> DT team, should I take this series through my tree?
>> Toke, Ack?
> No, of course not. The same as you asked some time ago: DTS never, NEVER
> goes via driver subsystem tree.
> 

Heh, you do not have any subsystem maintainers acks or reviews on DTS,
so this should not be considered. It's like me taking wireless patches
without your acks.

Best regards,
Krzysztof
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Jeff Johnson 5 months, 3 weeks ago
On 6/19/2025 10:39 PM, Krzysztof Kozlowski wrote:
> On 20/06/2025 07:32, Krzysztof Kozlowski wrote:
>> On 20/06/2025 02:33, Jeff Johnson wrote:
>>> On 6/8/2025 8:08 PM, Rosen Penev wrote:
>>>> First two commits are small cleanups to make the changes of the third
>>>> simpler. The fourth actually adds dts definitions to use ahb.
>>>>
>>>> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
>>>> v3: Use qcom prefix and wifi suffix as in other ath drivers.
>>>> v4: fix up dts example in Documentation
>>>> v5: move back to using qca prefix. It makes no sense to diverge between
>>>> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
>>>> is used for Quallcomm's ARM(64) stuff.
>>>>
>>>> Rosen Penev (5):
>>>>   wifi: ath9k: ahb: reorder declarations
>>>>   wifi: ath9k: ahb: reorder includes
>>>>   wifi: ath9k: ahb: replace id_table with of
>>>>   dt-bindings: net: wireless: ath9k: add OF bindings
>>>>   mips: dts: qca: add wmac support
>>>>
>>>>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>>>>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>>>>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>>>>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>>>>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>>>>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>>>>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>>>>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>>>>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>>>>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>>>>  10 files changed, 84 insertions(+), 41 deletions(-)
>>>>
>>>
>>> DT team, should I take this series through my tree?
>>> Toke, Ack?
>> No, of course not. The same as you asked some time ago: DTS never, NEVER
>> goes via driver subsystem tree.
>>
> 
> Heh, you do not have any subsystem maintainers acks or reviews on DTS,
> so this should not be considered. It's like me taking wireless patches
> without your acks.

That is why I was looking for clarification.
All the DT stuff had your R-B and hence why I asked Toke for his Ack.
Will DT team take the entire series (I'm ok with that)?
Or just the DTS and I should take the rest?

/jeff
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Krzysztof Kozlowski 5 months, 3 weeks ago
On 20/06/2025 17:27, Jeff Johnson wrote:
> On 6/19/2025 10:39 PM, Krzysztof Kozlowski wrote:
>> On 20/06/2025 07:32, Krzysztof Kozlowski wrote:
>>> On 20/06/2025 02:33, Jeff Johnson wrote:
>>>> On 6/8/2025 8:08 PM, Rosen Penev wrote:
>>>>> First two commits are small cleanups to make the changes of the third
>>>>> simpler. The fourth actually adds dts definitions to use ahb.
>>>>>
>>>>> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
>>>>> v3: Use qcom prefix and wifi suffix as in other ath drivers.
>>>>> v4: fix up dts example in Documentation
>>>>> v5: move back to using qca prefix. It makes no sense to diverge between
>>>>> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
>>>>> is used for Quallcomm's ARM(64) stuff.
>>>>>
>>>>> Rosen Penev (5):
>>>>>   wifi: ath9k: ahb: reorder declarations
>>>>>   wifi: ath9k: ahb: reorder includes
>>>>>   wifi: ath9k: ahb: replace id_table with of
>>>>>   dt-bindings: net: wireless: ath9k: add OF bindings
>>>>>   mips: dts: qca: add wmac support
>>>>>
>>>>>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>>>>>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>>>>>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>>>>>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>>>>>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>>>>>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>>>>>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>>>>>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>>>>>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>>>>>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>>>>>  10 files changed, 84 insertions(+), 41 deletions(-)
>>>>>
>>>>
>>>> DT team, should I take this series through my tree?
>>>> Toke, Ack?
>>> No, of course not. The same as you asked some time ago: DTS never, NEVER
>>> goes via driver subsystem tree.
>>>
>>
>> Heh, you do not have any subsystem maintainers acks or reviews on DTS,
>> so this should not be considered. It's like me taking wireless patches
>> without your acks.
> 
> That is why I was looking for clarification.
> All the DT stuff had your R-B and hence why I asked Toke for his Ack.
> Will DT team take the entire series (I'm ok with that)?
> Or just the DTS and I should take the rest?

It's not the DT team, we are not taking any DTS patches ever but
platform or SoC maintainers are taking DTS for their platform. So please
take only your subsystem - wireless drivers and wireless DT bindings -
leaving DTS for platform/SoC maintainers.

Best regards,
Krzysztof
Re: [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Toke Høiland-Jørgensen 5 months, 3 weeks ago
Rosen Penev <rosenp@gmail.com> writes:

> First two commits are small cleanups to make the changes of the third
> simpler. The fourth actually adds dts definitions to use ahb.
>
> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
> v3: Use qcom prefix and wifi suffix as in other ath drivers.
> v4: fix up dts example in Documentation
> v5: move back to using qca prefix. It makes no sense to diverge between
> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
> is used for Quallcomm's ARM(64) stuff.
>
> Rosen Penev (5):
>   wifi: ath9k: ahb: reorder declarations
>   wifi: ath9k: ahb: reorder includes
>   wifi: ath9k: ahb: replace id_table with of
>   dt-bindings: net: wireless: ath9k: add OF bindings
>   mips: dts: qca: add wmac support
>
>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++-
>  arch/mips/boot/dts/qca/ar9132.dtsi            |  9 +++
>  .../boot/dts/qca/ar9132_tl_wr1043nd_v1.dts    |  4 ++
>  arch/mips/boot/dts/qca/ar9331.dtsi            |  9 +++
>  arch/mips/boot/dts/qca/ar9331_dpt_module.dts  |  4 ++
>  .../mips/boot/dts/qca/ar9331_dragino_ms14.dts |  4 ++
>  arch/mips/boot/dts/qca/ar9331_omega.dts       |  4 ++
>  .../qca/ar9331_openembed_som9331_board.dts    |  4 ++
>  arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts   |  4 ++
>  drivers/net/wireless/ath/ath9k/ahb.c          | 60 +++++++------------
>  10 files changed, 84 insertions(+), 41 deletions(-)
>
> -- 
> 2.49.0


For the ath9k bits:

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Re: (subset) [PATCHv5 0/5] wifi: ath9k: add ahb OF support
Posted by Jeff Johnson 5 months, 2 weeks ago
On Sun, 08 Jun 2025 20:08:46 -0700, Rosen Penev wrote:
> First two commits are small cleanups to make the changes of the third
> simpler. The fourth actually adds dts definitions to use ahb.
> 
> v2: Add documentation, use kernel_ulong_t, and of_device_get_match_data
> v3: Use qcom prefix and wifi suffix as in other ath drivers.
> v4: fix up dts example in Documentation
> v5: move back to using qca prefix. It makes no sense to diverge between
> all the other drivers for MIPS based qualcomm devices. qcom as a prefix
> is used for Quallcomm's ARM(64) stuff.
> 
> [...]

Applied, thanks!

[1/5] wifi: ath9k: ahb: reorder declarations
      commit: 5cbfef9039f61691c87f522f8761d628033bc392
[2/5] wifi: ath9k: ahb: reorder includes
      commit: c8123302c01936d297e22adbd75cad38c5049f92
[3/5] dt-bindings: net: wireless: ath9k: add WIFI bindings
      commit: f902f2c39a807382353b4c6b8d8d4ac1f03aade9
[4/5] wifi: ath9k: ahb: replace id_table with of
      commit: 2fa490c0d7591918bed267059700f1c9e505e881

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>