[PATCH] init: Fix build warnings about export.h

Huacai Chen posted 1 patch 6 months, 2 weeks ago
init/initramfs.c | 1 +
init/main.c      | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
[PATCH] init: Fix build warnings about export.h
Posted by Huacai Chen 6 months, 2 weeks ago
After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1"), we get some build
warnings with W=1:

init/main.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
init/initramfs.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

So fix these build warnings for the init code.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 init/initramfs.c | 1 +
 init/main.c      | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/init/initramfs.c b/init/initramfs.c
index 72bad44a1d41..097673b97784 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/init.h>
 #include <linux/async.h>
+#include <linux/export.h>
 #include <linux/fs.h>
 #include <linux/slab.h>
 #include <linux/types.h>
diff --git a/init/main.c b/init/main.c
index 2cf5e9ea84d8..bfdf0fd76eb3 100644
--- a/init/main.c
+++ b/init/main.c
@@ -12,7 +12,8 @@
 
 #define DEBUG		/* Enable initcall_debug */
 
 #include <linux/types.h>
+#include <linux/export.h>
 #include <linux/extable.h>
 #include <linux/module.h>
 #include <linux/proc_fs.h>
-- 
2.47.1
Re: [PATCH] init: Fix build warnings about export.h
Posted by Masahiro Yamada 6 months, 1 week ago
On Sun, Jun 8, 2025 at 11:12 PM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> init/main.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> init/initramfs.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> So fix these build warnings for the init code.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>

Thank you for your contribution.

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


-- 
Best Regards
Masahiro Yamada