mips: boot: use 'targets' instead of extra-y in Makefile

[PATCH] mips: boot: use 'targets' instead of extra-y in Makefile

Posted by Masahiro Yamada 6 months, 2 weeks ago

vmlinux.bin.* files are built as prerequisites of other objects.
There is no need to use extra-y, which is planned for deprecation.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/mips/boot/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/Makefile b/arch/mips/boot/Makefile
index 196c44fa72d9..8473c4671702 100644
--- a/arch/mips/boot/Makefile
+++ b/arch/mips/boot/Makefile
@@ -54,10 +54,10 @@ UIMAGE_ENTRYADDR = $(VMLINUX_ENTRY_ADDRESS)
 # Compressed vmlinux images
 #
 
-extra-y += vmlinux.bin.bz2
-extra-y += vmlinux.bin.gz
-extra-y += vmlinux.bin.lzma
-extra-y += vmlinux.bin.lzo
+targets += vmlinux.bin.bz2
+targets += vmlinux.bin.gz
+targets += vmlinux.bin.lzma
+targets += vmlinux.bin.lzo
 
 $(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
 	$(call if_changed,bzip2)
-- 
2.43.0

Re: [PATCH] mips: boot: use 'targets' instead of extra-y in Makefile

Posted by Thomas Bogendoerfer 5 months, 2 weeks ago

On Sun, Jun 08, 2025 at 10:51:34AM +0900, Masahiro Yamada wrote:
> vmlinux.bin.* files are built as prerequisites of other objects.
> There is no need to use extra-y, which is planned for deprecation.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  arch/mips/boot/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/boot/Makefile b/arch/mips/boot/Makefile
> index 196c44fa72d9..8473c4671702 100644
> --- a/arch/mips/boot/Makefile
> +++ b/arch/mips/boot/Makefile
> @@ -54,10 +54,10 @@ UIMAGE_ENTRYADDR = $(VMLINUX_ENTRY_ADDRESS)
>  # Compressed vmlinux images
>  #
>  
> -extra-y += vmlinux.bin.bz2
> -extra-y += vmlinux.bin.gz
> -extra-y += vmlinux.bin.lzma
> -extra-y += vmlinux.bin.lzo
> +targets += vmlinux.bin.bz2
> +targets += vmlinux.bin.gz
> +targets += vmlinux.bin.lzma
> +targets += vmlinux.bin.lzo
>  
>  $(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
>  	$(call if_changed,bzip2)
> -- 
> 2.43.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]