drivers: char: SONYPI depends on HAS_IOPORT

[PATCH] drivers: char: SONYPI depends on HAS_IOPORT

Posted by Johannes Berg 6 months, 2 weeks ago

From: Johannes Berg <johannes.berg@intel.com>

It already depends on X86_32, but that's also set for ARCH=um.
Recent changes made UML no longer have IO port access since
it's not needed, but this driver uses it. Build it only for
HAS_IOPORT. This is pretty much the same as depending on X86,
but on the off-chance that HAS_IOPORT will ever be optional
on x86 HAS_IOPORT is the real prerequisite.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506060742.XR3HcxWA-lkp@intel.com/
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 drivers/char/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 8fb33c90482f..36295558dc85 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -237,7 +237,7 @@ config APPLICOM
 
 config SONYPI
 	tristate "Sony Vaio Programmable I/O Control Device support"
-	depends on X86_32 && PCI && INPUT
+	depends on X86_32 && PCI && INPUT && HAS_IOPORT
 	depends on ACPI_EC || !ACPI
 	help
 	  This driver enables access to the Sony Programmable I/O Control
-- 
2.49.0

Re: [PATCH] drivers: char: SONYPI depends on HAS_IOPORT

Posted by Randy Dunlap 6 months ago


On 6/6/25 12:12 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> It already depends on X86_32, but that's also set for ARCH=um.
> Recent changes made UML no longer have IO port access since
> it's not needed, but this driver uses it. Build it only for
> HAS_IOPORT. This is pretty much the same as depending on X86,
> but on the off-chance that HAS_IOPORT will ever be optional
> on x86 HAS_IOPORT is the real prerequisite.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506060742.XR3HcxWA-lkp@intel.com/
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/char/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 8fb33c90482f..36295558dc85 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -237,7 +237,7 @@ config APPLICOM
>  
>  config SONYPI
>  	tristate "Sony Vaio Programmable I/O Control Device support"
> -	depends on X86_32 && PCI && INPUT
> +	depends on X86_32 && PCI && INPUT && HAS_IOPORT
>  	depends on ACPI_EC || !ACPI
>  	help
>  	  This driver enables access to the Sony Programmable I/O Control

-- 
~Randy

Re: [PATCH] drivers: char: SONYPI depends on HAS_IOPORT

Posted by Arnd Bergmann 6 months, 2 weeks ago

On Fri, Jun 6, 2025, at 09:12, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> It already depends on X86_32, but that's also set for ARCH=um.
> Recent changes made UML no longer have IO port access since
> it's not needed, but this driver uses it. Build it only for
> HAS_IOPORT. This is pretty much the same as depending on X86,
> but on the off-chance that HAS_IOPORT will ever be optional
> on x86 HAS_IOPORT is the real prerequisite.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202506060742.XR3HcxWA-lkp@intel.com/
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

You beat me to this one, I was about to send the same thing.

    Arnd