1. Patchew
  2. linux
  3. View series

[PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.

Suleiman Souhlal posted 1 patch 6 months, 2 weeks ago
There is a newer version of this series
tools/bpf/resolve_btfids/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Suleiman Souhlal 6 months, 2 weeks ago 
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGS when preparing the step libraries for
resolve_btfids.

Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
when building tools in parallel"), MAKEFLAGS would have been set to a
value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
fact that we weren't properly overriding it.

Cc: stable@vger.kernel.org
Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
Signed-of-by: Suleiman Souhlal <suleiman@google.com>
---
 tools/bpf/resolve_btfids/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile
index afbddea3a39c..ce1b556dfa90 100644
--- a/tools/bpf/resolve_btfids/Makefile
+++ b/tools/bpf/resolve_btfids/Makefile
@@ -17,7 +17,7 @@ endif
 
 # Overrides for the prepare step libraries.
 HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \
-		  CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
+		  CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
 
 RM      ?= rm
 HOSTCC  ?= gcc
-- 
2.50.0.rc0.642.g800a2b2222-goog
[RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Suleiman Souhlal 6 months, 2 weeks ago 
When cross compiling the kernel with clang, we need to override
CLANG_CROSS_FLAGS when preparing the step libraries for
resolve_btfids.

Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
when building tools in parallel"), MAKEFLAGS would have been set to a
value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
fact that we weren't properly overriding it.

Cc: stable@vger.kernel.org
Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
Signed-off-by: Suleiman Souhlal <suleiman@google.com>
---
 tools/bpf/resolve_btfids/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile
index afbddea3a39c..ce1b556dfa90 100644
--- a/tools/bpf/resolve_btfids/Makefile
+++ b/tools/bpf/resolve_btfids/Makefile
@@ -17,7 +17,7 @@ endif
 
 # Overrides for the prepare step libraries.
 HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)" \
-		  CROSS_COMPILE="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
+		  CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
 
 RM      ?= rm
 HOSTCC  ?= gcc
-- 
2.50.0.rc0.642.g800a2b2222-goog
Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Greg KH 6 months, 2 weeks ago 
On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
> When cross compiling the kernel with clang, we need to override
> CLANG_CROSS_FLAGS when preparing the step libraries for
> resolve_btfids.
> 
> Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> when building tools in parallel"), MAKEFLAGS would have been set to a
> value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> fact that we weren't properly overriding it.
> 
> Cc: stable@vger.kernel.org
> Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> ---
>  tools/bpf/resolve_btfids/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You forgot to say why this is a resend :(
Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Suleiman Souhlal 6 months, 2 weeks ago 
On Fri, Jun 6, 2025 at 3:05 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
> > When cross compiling the kernel with clang, we need to override
> > CLANG_CROSS_FLAGS when preparing the step libraries for
> > resolve_btfids.
> >
> > Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> > when building tools in parallel"), MAKEFLAGS would have been set to a
> > value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> > fact that we weren't properly overriding it.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> > Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> > ---
> >  tools/bpf/resolve_btfids/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> You forgot to say why this is a resend :(

I wasn't sure how to say it. It didn't occur to me that I could have
replied to it with the reason.

It was because I had "Signed-of-by:" instead of "Signed-off-by:".

-- Suleiman
Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Greg KH 6 months, 2 weeks ago 
On Fri, Jun 06, 2025 at 03:08:09PM +0900, Suleiman Souhlal wrote:
> On Fri, Jun 6, 2025 at 3:05 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
> > > When cross compiling the kernel with clang, we need to override
> > > CLANG_CROSS_FLAGS when preparing the step libraries for
> > > resolve_btfids.
> > >
> > > Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> > > when building tools in parallel"), MAKEFLAGS would have been set to a
> > > value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> > > fact that we weren't properly overriding it.
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> > > Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> > > ---
> > >  tools/bpf/resolve_btfids/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > You forgot to say why this is a resend :(
> 
> I wasn't sure how to say it. It didn't occur to me that I could have
> replied to it with the reason.

That goes below the --- line and it would be a v2, not a RESEND as you
changed something:

> It was because I had "Signed-of-by:" instead of "Signed-off-by:".

Which means it was not identical to the first version (a RESEND means a
maintainer can take either as they are the same).

thanks,

greg k-h
Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Suleiman Souhlal 6 months, 2 weeks ago 
On Fri, Jun 6, 2025 at 3:20 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jun 06, 2025 at 03:08:09PM +0900, Suleiman Souhlal wrote:
> > On Fri, Jun 6, 2025 at 3:05 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
> > > > When cross compiling the kernel with clang, we need to override
> > > > CLANG_CROSS_FLAGS when preparing the step libraries for
> > > > resolve_btfids.
> > > >
> > > > Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> > > > when building tools in parallel"), MAKEFLAGS would have been set to a
> > > > value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> > > > fact that we weren't properly overriding it.
> > > >
> > > > Cc: stable@vger.kernel.org
> > > > Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> > > > Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> > > > ---
> > > >  tools/bpf/resolve_btfids/Makefile | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > You forgot to say why this is a resend :(
> >
> > I wasn't sure how to say it. It didn't occur to me that I could have
> > replied to it with the reason.
>
> That goes below the --- line and it would be a v2, not a RESEND as you
> changed something:
>
> > It was because I had "Signed-of-by:" instead of "Signed-off-by:".
>
> Which means it was not identical to the first version (a RESEND means a
> maintainer can take either as they are the same).

Ah. Should I resend it as a v2?

Thanks,
-- Suleiman
Re: [RESEND][PATCH] tools/resolve_btfids: Fix build when cross compiling kernel with clang.
Posted by Greg KH 6 months, 2 weeks ago 
On Fri, Jun 06, 2025 at 03:21:45PM +0900, Suleiman Souhlal wrote:
> On Fri, Jun 6, 2025 at 3:20 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Jun 06, 2025 at 03:08:09PM +0900, Suleiman Souhlal wrote:
> > > On Fri, Jun 6, 2025 at 3:05 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Fri, Jun 06, 2025 at 02:36:50PM +0900, Suleiman Souhlal wrote:
> > > > > When cross compiling the kernel with clang, we need to override
> > > > > CLANG_CROSS_FLAGS when preparing the step libraries for
> > > > > resolve_btfids.
> > > > >
> > > > > Prior to commit d1d096312176 ("tools: fix annoying "mkdir -p ..." logs
> > > > > when building tools in parallel"), MAKEFLAGS would have been set to a
> > > > > value that wouldn't set a value for CLANG_CROSS_FLAGS, hiding the
> > > > > fact that we weren't properly overriding it.
> > > > >
> > > > > Cc: stable@vger.kernel.org
> > > > > Fixes: 56a2df7615fa ("tools/resolve_btfids: Compile resolve_btfids as host program")
> > > > > Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> > > > > ---
> > > > >  tools/bpf/resolve_btfids/Makefile | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > You forgot to say why this is a resend :(
> > >
> > > I wasn't sure how to say it. It didn't occur to me that I could have
> > > replied to it with the reason.
> >
> > That goes below the --- line and it would be a v2, not a RESEND as you
> > changed something:
> >
> > > It was because I had "Signed-of-by:" instead of "Signed-off-by:".
> >
> > Which means it was not identical to the first version (a RESEND means a
> > maintainer can take either as they are the same).
> 
> Ah. Should I resend it as a v2?

Think about what you would want to see if you were on the recieving end
of thousands of patches and had to try to figure out what to ignore and
what to pay attention to...

thanks,

greg k-h

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.