[PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase

André Draszik posted 17 patches 6 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by André Draszik 6 months, 2 weeks ago
Using lowercase for the buck and ldo nodenames is preferred, as
evidenced e.g. in [1].

Convert the example here to lowercase before we add any bindings
describing the s2mpg1x regulators that will enforce the spelling.

Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
index 9785aac3b5f34955bbfe2718eec48581d050954f..62a3a7dac5bd250a7f216c72f3315cd9632d93e1 100644
--- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
+++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
@@ -64,7 +64,7 @@ examples:
             interrupts-extended = <&gpa0 6 IRQ_TYPE_LEVEL_LOW>;
 
             regulators {
-                LDO1 {
+                ldo1m {
                     regulator-name = "vdd_ldo1";
                     regulator-min-microvolt = <700000>;
                     regulator-max-microvolt = <1300000>;
@@ -73,7 +73,7 @@ examples:
 
                 // ...
 
-                BUCK1 {
+                buck8m {
                     regulator-name = "vdd_mif";
                     regulator-min-microvolt = <450000>;
                     regulator-max-microvolt = <1300000>;

-- 
2.50.0.rc0.604.gd4ff7b7c86-goog

Re: [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by Rob Herring (Arm) 5 months, 3 weeks ago
On Fri, 06 Jun 2025 16:02:57 +0100, André Draszik wrote:
> Using lowercase for the buck and ldo nodenames is preferred, as
> evidenced e.g. in [1].
> 
> Convert the example here to lowercase before we add any bindings
> describing the s2mpg1x regulators that will enforce the spelling.
> 
> Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by Krzysztof Kozlowski 6 months, 1 week ago
On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote:
> Using lowercase for the buck and ldo nodenames is preferred, as
> evidenced e.g. in [1].
> 
> Convert the example here to lowercase before we add any bindings
> describing the s2mpg1x regulators that will enforce the spelling.
> 
> Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

So this is also a dependency for the rest of the patches?

Best regards,
Krzysztof
Re: [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by André Draszik 6 months, 1 week ago
Hi Krzysztof,

On Wed, 2025-06-11 at 11:04 +0200, Krzysztof Kozlowski wrote:
> On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote:
> > Using lowercase for the buck and ldo nodenames is preferred, as
> > evidenced e.g. in [1].
> > 
> > Convert the example here to lowercase before we add any bindings
> > describing the s2mpg1x regulators that will enforce the spelling.
> > 
> > Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
> > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> So this is also a dependency for the rest of the patches?

My thinking was that it makes sense to have it in context with
the other patches, but it indeed could go stand-alone if that's the
preference.

Cheers,
Andre'
Re: [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by André Draszik 5 months, 3 weeks ago
Hi Krzysztof,

On Wed, 2025-06-11 at 10:08 +0100, André Draszik wrote:
> Hi Krzysztof,
> 
> On Wed, 2025-06-11 at 11:04 +0200, Krzysztof Kozlowski wrote:
> > On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote:
> > > Using lowercase for the buck and ldo nodenames is preferred, as
> > > evidenced e.g. in [1].
> > > 
> > > Convert the example here to lowercase before we add any bindings
> > > describing the s2mpg1x regulators that will enforce the spelling.
> > > 
> > > Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
> > > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > So this is also a dependency for the rest of the patches?
> 
> My thinking was that it makes sense to have it in context with
> the other patches, but it indeed could go stand-alone if that's the
> preference.

Can you take just that patch as-is from this series (then it's at
least out of the way :-), or should I resend it separately?

Cheers,
Andre'
Re: [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase
Posted by Rob Herring 5 months, 3 weeks ago
On Wed, Jun 25, 2025 at 04:05:34PM +0100, André Draszik wrote:
> Hi Krzysztof,
> 
> On Wed, 2025-06-11 at 10:08 +0100, André Draszik wrote:
> > Hi Krzysztof,
> > 
> > On Wed, 2025-06-11 at 11:04 +0200, Krzysztof Kozlowski wrote:
> > > On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote:
> > > > Using lowercase for the buck and ldo nodenames is preferred, as
> > > > evidenced e.g. in [1].
> > > > 
> > > > Convert the example here to lowercase before we add any bindings
> > > > describing the s2mpg1x regulators that will enforce the spelling.
> > > > 
> > > > Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1]
> > > > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > So this is also a dependency for the rest of the patches?
> > 
> > My thinking was that it makes sense to have it in context with
> > the other patches, but it indeed could go stand-alone if that's the
> > preference.
> 
> Can you take just that patch as-is from this series (then it's at
> least out of the way :-), or should I resend it separately?

No. If you take it out, then the rest of the series will have warnings.

Rob