Hi Jacopo,
Thank you for tidying this up!
On Fri, 6 Jun 2025 at 11:29, Jacopo Mondi <jacopo.mondi@ideasonboard.com> wrote:
>
> A comment in the pisp_be driver references the
> pispbe_schedule_internal() function which doesn't exist.
>
> Drop it.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
> ---
> drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> index 7596ae1f7de6..b1449245f394 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> @@ -368,10 +368,7 @@ static void pispbe_xlate_addrs(struct pispbe_dev *pispbe,
> ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE],
> &pispbe->node[MAIN_INPUT_NODE]);
> if (ret <= 0) {
> - /*
> - * This shouldn't happen; pispbe_schedule_internal should insist
> - * on an input.
> - */
> + /* Shouldn't happen, we have validated an input is available. */
> dev_warn(pispbe->dev, "ISP-BE missing input\n");
> hw_en->bayer_enables = 0;
> hw_en->rgb_enables = 0;
>
> --
> 2.49.0
>