ARM: dts: qcom: msm8960: use macros for interrupts

[PATCH] ARM: dts: qcom: msm8960: use macros for interrupts

Posted by Max Shevchenko via B4 Relay 6 months, 2 weeks ago

From: Max Shevchenko <wctrl@proton.me>

Replace the raw values with macros. No changes to the output

Tested-by: Rudraksha Gupta <guptarud@gmail.com>
Signed-off-by: Max Shevchenko <wctrl@proton.me>
---
Replace the raw values with macros. No changes to the output
---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index 865fe7cc39511d7cb9ec5c4b12100404f77e2989..13572d0b1d5572cc5b9c3a136a6ea6267b8625da 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -18,7 +18,7 @@ / {
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
-		interrupts = <GIC_PPI 14 0x304>;
+		interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
 
 		cpu@0 {
 			compatible = "qcom,krait";
@@ -54,7 +54,7 @@ memory@80000000 {
 
 	cpu-pmu {
 		compatible = "qcom,krait-pmu";
-		interrupts = <GIC_PPI 10 0x304>;
+		interrupts = <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
 		qcom,no-pc-write;
 	};
 
@@ -107,9 +107,9 @@ intc: interrupt-controller@2000000 {
 		timer@200a000 {
 			compatible = "qcom,kpss-wdt-msm8960", "qcom,kpss-timer",
 				     "qcom,msm-timer";
-			interrupts = <GIC_PPI 1 0x301>,
-				     <GIC_PPI 2 0x301>,
-				     <GIC_PPI 3 0x301>;
+			interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+				     <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+				     <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
 			reg = <0x0200a000 0x100>;
 			clock-frequency = <27000000>;
 			cpu-offset = <0x80000>;

---
base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
change-id: 20250603-msm8960-irq-macros-6dafa735cecc

Best regards,
-- 
Max Shevchenko <wctrl@proton.me>

Re: [PATCH] ARM: dts: qcom: msm8960: use macros for interrupts

Posted by Bjorn Andersson 6 months, 1 week ago

On Fri, 06 Jun 2025 14:03:51 +0300, Max Shevchenko wrote:
> Replace the raw values with macros. No changes to the output
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: msm8960: use macros for interrupts
      commit: da7811bb0edbea0208800cfa16516a47b8d45747

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] ARM: dts: qcom: msm8960: use macros for interrupts

Posted by Dmitry Baryshkov 6 months, 2 weeks ago

On Fri, Jun 06, 2025 at 02:03:51PM +0300, Max Shevchenko via B4 Relay wrote:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Replace the raw values with macros. No changes to the output
> 
> Tested-by: Rudraksha Gupta <guptarud@gmail.com>
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
> Replace the raw values with macros. No changes to the output
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH] ARM: dts: qcom: msm8960: use macros for interrupts

Posted by Konrad Dybcio 6 months, 2 weeks ago

On 6/6/25 1:03 PM, Max Shevchenko via B4 Relay wrote:
> From: Max Shevchenko <wctrl@proton.me>
> 
> Replace the raw values with macros. No changes to the output
> 
> Tested-by: Rudraksha Gupta <guptarud@gmail.com>
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad