With W=1, gcc complains correctly:

    mpt3sas_ctl.c: In function ‘mpt3sas_send_mctp_passthru_req’:
    mpt3sas_ctl.c:2917:29: error: variable ‘mpi_reply’ set but not used [-Werror=unused-but-set-variable]
     2917 |         MPI2DefaultReply_t *mpi_reply;
          |                             ^~~~~~~~~

Drop the unused assignment and variable.

Fixes: c72be4b5bb7c ("scsi: mpt3sas: Add support for MCTP Passthrough commands")
Cc: stable@vger.kernel.org
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/scsi/mpt3sas/mpt3sas_ctl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index 02fc204b9bf7b276115bf6db52746155381799fd..3b951589feeb6c13094ea44b494ca3050a309b15 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -2914,7 +2914,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command)
 {
 	struct MPT3SAS_ADAPTER *ioc;
 	MPI2RequestHeader_t *mpi_request = NULL, *request;
-	MPI2DefaultReply_t *mpi_reply;
 	Mpi26MctpPassthroughRequest_t *mctp_passthru_req;
 	u16 smid;
 	unsigned long timeout;
@@ -3022,8 +3021,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command)
 		goto issue_host_reset;
 	}
 
-	mpi_reply = ioc->ctl_cmds.reply;
-
 	/* copy out xdata to user */
 	if (data_in_sz)
 		memcpy(command->data_in_buf_ptr, data_in, data_in_sz);

---
base-commit: a0bea9e39035edc56a994630e6048c8a191a99d8
change-id: 20250606-mpt3sas-15563809f705

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

On Fri, 06 Jun 2025 16:29:43 +0100, André Draszik wrote:

> With W=1, gcc complains correctly:
> 
>     mpt3sas_ctl.c: In function ‘mpt3sas_send_mctp_passthru_req’:
>     mpt3sas_ctl.c:2917:29: error: variable ‘mpi_reply’ set but not used [-Werror=unused-but-set-variable]
>      2917 |         MPI2DefaultReply_t *mpi_reply;
>           |                             ^~~~~~~~~
> 
> [...]

Applied to 6.17/scsi-queue, thanks!

[1/1] scsi: mpt3sas: drop unused variable in mpt3sas_send_mctp_passthru_req()
      https://git.kernel.org/mkp/scsi/c/0ec996edf4fd

-- 
Martin K. Petersen	Oracle Linux Engineering

André,

> With W=1, gcc complains correctly:
>
>     mpt3sas_ctl.c: In function ‘mpt3sas_send_mctp_passthru_req’:
>     mpt3sas_ctl.c:2917:29: error: variable ‘mpi_reply’ set but not used [-Werror=unused-but-set-variable]
>      2917 |         MPI2DefaultReply_t *mpi_reply;
>           |                             ^~~~~~~~~
>
> Drop the unused assignment and variable.

Applied to 6.17/scsi-staging, thanks!

-- 
Martin K. Petersen