[PATCH] binder: fix reversed pid/tid in log

Carlos Llamas posted 1 patch 6 months, 2 weeks ago
drivers/android/binder.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
[PATCH] binder: fix reversed pid/tid in log
Posted by Carlos Llamas 6 months, 2 weeks ago
The "pid:tid" format is used consistently throughout the driver's logs
with the exception of this one place where the arguments are reversed.
Let's fix that. Also, collapse a multi-line comment into a single line.

Cc: Steven Moreland <smoreland@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
 drivers/android/binder.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c463ca4a8fff..2bd8ac943171 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3144,10 +3144,8 @@ static void binder_transaction(struct binder_proc *proc,
 		}
 		if (!target_node) {
 			binder_txn_error("%d:%d cannot find target node\n",
-				thread->pid, proc->pid);
-			/*
-			 * return_error is set above
-			 */
+					 proc->pid, thread->pid);
+			/* return_error is set above */
 			return_error_param = -EINVAL;
 			return_error_line = __LINE__;
 			goto err_dead_binder;
-- 
2.49.0.1266.g31b7d2e469-goog
Re: [PATCH] binder: fix reversed pid/tid in log
Posted by Alice Ryhl 6 months, 2 weeks ago
On Thu, Jun 05, 2025 at 02:19:29PM +0000, Carlos Llamas wrote:
> The "pid:tid" format is used consistently throughout the driver's logs
> with the exception of this one place where the arguments are reversed.
> Let's fix that. Also, collapse a multi-line comment into a single line.
> 
> Cc: Steven Moreland <smoreland@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>