[v3] KVM: arm64: selftests: arch_timer_edge_cases fixes

[PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

Posted by Sebastian Ott 6 months, 2 weeks ago

Some small fixes for arch_timer_edge_cases that I stumbled upon
while debugging failures for this selftest on ampere-one.

Changes since v1:
 * determine effective counter width based on suggestions from Marc
Changes since v2:
 * new patch to fix xval initialization

I've done tests with this on various machines - no issues during
several hundreds of test runs.

v1: https://lore.kernel.org/kvmarm/20250509143312.34224-1-sebott@redhat.com/
v2: https://lore.kernel.org/kvmarm/20250527142434.25209-1-sebott@redhat.com/

Sebastian Ott (4):
  KVM: arm64: selftests: fix help text for arch_timer_edge_cases
  KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases
  KVM: arm64: selftests: arch_timer_edge_cases - fix xval init
  KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width

 .../kvm/arm64/arch_timer_edge_cases.c         | 39 ++++++++++++-------
 1 file changed, 25 insertions(+), 14 deletions(-)


base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
-- 
2.49.0

Re: [PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

Posted by Miguel Luis 6 months, 1 week ago

Hi Sebastian,

Thanks in advance.

> On 5 Jun 2025, at 10:36, Sebastian Ott <sebott@redhat.com> wrote:
> 
> Some small fixes for arch_timer_edge_cases that I stumbled upon
> while debugging failures for this selftest on ampere-one.
> 

I’ve tested this test under three circumstances:

1) Original (!HAS_EL2 && !HAS_EL2_E2H0)

2) HAS_EL2 && HAS_EL2_E2H0

3) HAS_EL2 && !HAS_EL2_E2H0


Tests 1) and 2) returned in approx. the same amount of real time (about 12s) although 3) doesn’t
seem to return at all.

I’ve tested it on ampere-one.

Miguel

> Changes since v1:
> * determine effective counter width based on suggestions from Marc
> Changes since v2:
> * new patch to fix xval initialization
> 
> I've done tests with this on various machines - no issues during
> several hundreds of test runs.
> 
> v1: https://lore.kernel.org/kvmarm/20250509143312.34224-1-sebott@redhat.com/
> v2: https://lore.kernel.org/kvmarm/20250527142434.25209-1-sebott@redhat.com/
> 
> Sebastian Ott (4):
>  KVM: arm64: selftests: fix help text for arch_timer_edge_cases
>  KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases
>  KVM: arm64: selftests: arch_timer_edge_cases - fix xval init
>  KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width
> 
> .../kvm/arm64/arch_timer_edge_cases.c         | 39 ++++++++++++-------
> 1 file changed, 25 insertions(+), 14 deletions(-)
> 
> 
> base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
> -- 
> 2.49.0
> 
>

Re: [PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

Posted by Sebastian Ott 6 months, 1 week ago

Hej Miguel,

On Mon, 9 Jun 2025, Miguel Luis wrote:
>> On 5 Jun 2025, at 10:36, Sebastian Ott <sebott@redhat.com> wrote:
>>
>> Some small fixes for arch_timer_edge_cases that I stumbled upon
>> while debugging failures for this selftest on ampere-one.
>>
>
> I’ve tested this test under three circumstances:
>
> 1) Original (!HAS_EL2 && !HAS_EL2_E2H0)
>
> 2) HAS_EL2 && HAS_EL2_E2H0
>
> 3) HAS_EL2 && !HAS_EL2_E2H0
>
> Tests 1) and 2) returned in approx. the same amount of real time (about 12s) although 3) doesn’t
> seem to return at all.

I've never really looked at nested stuff, I'll try to set smth up and see
if I can reproduce that..

Thanks,
Sebastian

Re: [PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

Posted by Marc Zyngier 6 months, 2 weeks ago

On Thu, 05 Jun 2025 12:36:09 +0200, Sebastian Ott wrote:
> Some small fixes for arch_timer_edge_cases that I stumbled upon
> while debugging failures for this selftest on ampere-one.
> 
> Changes since v1:
>  * determine effective counter width based on suggestions from Marc
> Changes since v2:
>  * new patch to fix xval initialization
> 
> [...]

Applied to fixes, thanks!

[1/4] KVM: arm64: selftests: fix help text for arch_timer_edge_cases
      commit: 9a9864fd09c7e52440c05e70609bf5ee8da425d0
[2/4] KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases
      commit: 050632ae6571d0f148fa0d4b90b6409a12645461
[3/4] KVM: arm64: selftests: arch_timer_edge_cases - fix xval init
      commit: 05ce38d489dbc96eb1dd700b287f949cb8cc0610
[4/4] KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width
      commit: fad4cf944839da7f5c3376243aa353295c88f588

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.