From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>

Corrected to "maximum" as my very first patch to the kernel.
Just to get used to the contribution workflow.

Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
---
 drivers/tty/moxa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index 329b30fac8fc..d32fb37e2e1c 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -1628,9 +1628,9 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
  *
  *           return:    0       : this port is invalid or baud < 50
  *                      50 - 115200 : the real baud rate set to the port, if
- *                                    the argument baud is large than maximun
+ *                                    the argument baud is large than maximum
  *                                    available baud rate, the real setting
- *                                    baud rate will be the maximun baud rate.
+ *                                    baud rate will be the maximum baud rate.
  *
  *
  *      Function 12:    Configure the port.
-- 
2.34.1

On Wed,  4 Jun 2025 20:09:03 -0400
shanmukh.iyer@gmail.com wrote:

Hi Shanmukh,

> From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
> 
> Corrected to "maximum" as my very first patch to the kernel.
> Just to get used to the contribution workflow.
> 
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
> ---
>  drivers/tty/moxa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 329b30fac8fc..d32fb37e2e1c 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1628,9 +1628,9 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
>   *
>   *           return:    0       : this port is invalid or baud < 50
>   *                      50 - 115200 : the real baud rate set to the port, if
> - *                                    the argument baud is large than maximun
> + *                                    the argument baud is large than maximum

while at it:

s/large/larger

>   *                                    available baud rate, the real setting
> - *                                    baud rate will be the maximun baud rate.
> + *                                    baud rate will be the maximum baud rate.
>   *
>   *
>   *      Function 12:    Configure the port.
> -- 
> 2.34.1
> 
> 


-- 
Hugo Villeneuve

From: Shanmukh Iyer <shanmukh.iyer@gmail.com>

Corrected some spelling and grammar in the comments, such as:
- Units (baud -> baud rate)
- Sentence flow
- typos

This is part of my first patch to get familiar with
the kernel's patch contribution workflow.

Signed-off-by: Shanmukh Iyer <shanmukh.iyer@gmail.com>
---
 drivers/tty/moxa.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index 329b30fac8fc..bf86f24e5655 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -1627,10 +1627,11 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
  *           long baud          : baud rate (50 - 115200)
  *
  *           return:    0       : this port is invalid or baud < 50
- *                      50 - 115200 : the real baud rate set to the port, if
- *                                    the argument baud is large than maximun
- *                                    available baud rate, the real setting
- *                                    baud rate will be the maximun baud rate.
+ *                      50 - 115200 : the real baud rate is set to the port, if
+ *                                    the argument baud rate is larger than 
+ *                                    the maximum available baud rate, the 
+ *                                    real setting baud rate will be the 
+ *                                    maximum baud rate.
  *
  *
  *      Function 12:    Configure the port.
-- 
2.34.1

On 10. 06. 25, 1:34, shanmukh.iyer@gmail.com wrote:
> From: Shanmukh Iyer <shanmukh.iyer@gmail.com>
> 
> Corrected some spelling and grammar in the comments, such as:
> - Units (baud -> baud rate)
> - Sentence flow
> - typos
> 
> This is part of my first patch to get familiar with
> the kernel's patch contribution workflow.
> 
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@gmail.com>
> ---

v2 changelog missing here now.

>   drivers/tty/moxa.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 329b30fac8fc..bf86f24e5655 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1627,10 +1627,11 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
>    *           long baud          : baud rate (50 - 115200)
>    *
>    *           return:    0       : this port is invalid or baud < 50
> - *                      50 - 115200 : the real baud rate set to the port, if
> - *                                    the argument baud is large than maximun
> - *                                    available baud rate, the real setting
> - *                                    baud rate will be the maximun baud rate.
> + *                      50 - 115200 : the real baud rate is set to the port, if

the new "is" looks superfluous.

> + *                                    the argument baud rate is larger than
> + *                                    the maximum available baud rate, the
> + *                                    real setting baud rate will be the
> + *                                    maximum baud rate.
>    *
>    *
>    *      Function 12:    Configure the port.


-- 
js
suse labs

On 05. 06. 25, 2:09, shanmukh.iyer@gmail.com wrote:
> From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
> 
> Corrected to "maximum" as my very first patch to the kernel.
> Just to get used to the contribution workflow.
> 
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

-- 
js
suse labs