[v2] media: uvcvideo: Add support for orientation and rotation.

[PATCH v2 01/12] media: uvcvideo: Always set default_value

Posted by Ricardo Ribalda 6 months, 2 weeks ago

If the control does not support GET_DEF, the field default_value will be
left uninitialized during queryctrl.

Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/usb/uvc/uvc_ctrl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 44b6513c526421943bb9841fb53dc5f8e9f93f02..47e8ccc39234d1769384b55539a21df07f3d57c7 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -1497,6 +1497,8 @@ static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain,
 	if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) {
 		v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping,
 				UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF));
+	} else {
+		v4l2_ctrl->default_value = 0;
 	}
 
 	switch (mapping->v4l2_type) {

-- 
2.50.0.rc0.642.g800a2b2222-goog

Re: [PATCH v2 01/12] media: uvcvideo: Always set default_value

Posted by Hans de Goede 5 months, 1 week ago

Hi,

On 5-Jun-25 19:52, Ricardo Ribalda wrote:
> If the control does not support GET_DEF, the field default_value will be
> left uninitialized during queryctrl.
> 
> Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Thanks, patch looks good to me,

Reviewed-by: Hans de Goede <hansg@kernel.org>

with Laurent's remarks addressed.

Regards,

Hans

> ---
>  drivers/media/usb/uvc/uvc_ctrl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> index 44b6513c526421943bb9841fb53dc5f8e9f93f02..47e8ccc39234d1769384b55539a21df07f3d57c7 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -1497,6 +1497,8 @@ static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain,
>  	if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) {
>  		v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping,
>  				UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF));
> +	} else {
> +		v4l2_ctrl->default_value = 0;
>  	}
>  
>  	switch (mapping->v4l2_type) {
>

Re: [PATCH v2 01/12] media: uvcvideo: Always set default_value

Posted by Laurent Pinchart 5 months, 3 weeks ago

Hi Ricardo,

Thank you for the patch.

On Thu, Jun 05, 2025 at 05:52:54PM +0000, Ricardo Ribalda wrote:
> If the control does not support GET_DEF, the field default_value will be
> left uninitialized during queryctrl.
> 
> Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")

Media CI rules require a Cc: stable.

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/usb/uvc/uvc_ctrl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> index 44b6513c526421943bb9841fb53dc5f8e9f93f02..47e8ccc39234d1769384b55539a21df07f3d57c7 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -1497,6 +1497,8 @@ static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain,
>  	if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) {
>  		v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping,
>  				UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF));
> +	} else {
> +		v4l2_ctrl->default_value = 0;
>  	}

While at it we can drop the curly braces.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>  	switch (mapping->v4l2_type) {

-- 
Regards,

Laurent Pinchart