selftests/mm: Skip failed memfd setups in gup_longterm

[PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

Posted by Mark Brown 6 months, 2 weeks ago

Unlike the other cases gup_longterm's memfd tests previously skipped the
test when failing to set up the file descriptor to test, restore this
behaviour.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/mm/gup_longterm.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
index 8a97ac5176a4..29047d2e0c49 100644
--- a/tools/testing/selftests/mm/gup_longterm.c
+++ b/tools/testing/selftests/mm/gup_longterm.c
@@ -298,8 +298,11 @@ static void run_with_memfd(test_fn fn, const char *desc)
 	log_test_start("%s ... with memfd", desc);
 
 	fd = memfd_create("test", 0);
-	if (fd < 0)
+	if (fd < 0) {
 		ksft_print_msg("memfd_create() failed (%s)\n", strerror(errno));
+		log_test_result(KSFT_SKIP);
+		return;
+	}
 
 	fn(fd, pagesize);
 	close(fd);
@@ -366,6 +369,8 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc,
 	fd = memfd_create("test", flags);
 	if (fd < 0) {
 		ksft_print_msg("memfd_create() failed (%s)\n", strerror(errno));
+		log_test_result(KSFT_SKIP);
+		return;
 	}
 
 	fn(fd, hugetlbsize);

---
base-commit: ec7714e4947909190ffb3041a03311a975350fe0
change-id: 20250603-selftest-mm-gup-longterm-tweaks-e685a8ae9751

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

Posted by Lorenzo Stoakes 6 months, 2 weeks ago

On Thu, Jun 05, 2025 at 10:34:31PM +0100, Mark Brown wrote:
> Unlike the other cases gup_longterm's memfd tests previously skipped the
> test when failing to set up the file descriptor to test, restore this
> behaviour.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Thanks, LGTM. I tested locally and this resolves the issue, appreciate it!

Feel free to add:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Tested-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  tools/testing/selftests/mm/gup_longterm.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
> index 8a97ac5176a4..29047d2e0c49 100644
> --- a/tools/testing/selftests/mm/gup_longterm.c
> +++ b/tools/testing/selftests/mm/gup_longterm.c
> @@ -298,8 +298,11 @@ static void run_with_memfd(test_fn fn, const char *desc)
>  	log_test_start("%s ... with memfd", desc);
>
>  	fd = memfd_create("test", 0);
> -	if (fd < 0)
> +	if (fd < 0) {
>  		ksft_print_msg("memfd_create() failed (%s)\n", strerror(errno));
> +		log_test_result(KSFT_SKIP);
> +		return;
> +	}
>
>  	fn(fd, pagesize);
>  	close(fd);
> @@ -366,6 +369,8 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc,
>  	fd = memfd_create("test", flags);
>  	if (fd < 0) {
>  		ksft_print_msg("memfd_create() failed (%s)\n", strerror(errno));
> +		log_test_result(KSFT_SKIP);
> +		return;
>  	}
>
>  	fn(fd, hugetlbsize);
>
> ---
> base-commit: ec7714e4947909190ffb3041a03311a975350fe0
> change-id: 20250603-selftest-mm-gup-longterm-tweaks-e685a8ae9751
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>

Re: [PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

Posted by Andrew Morton 6 months, 2 weeks ago

On Thu, 05 Jun 2025 22:34:31 +0100 Mark Brown <broonie@kernel.org> wrote:

> Unlike the other cases gup_longterm's memfd tests previously skipped the
> test when failing to set up the file descriptor to test, restore this
> behaviour.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

I added a bunch of stuff to this.  Please check?


From: Mark Brown <broonie@kernel.org>
Subject: selftests/mm: skip failed memfd setups in gup_longterm
Date: Thu, 05 Jun 2025 22:34:31 +0100

Unlike the other cases gup_longterm's memfd tests previously skipped the
test when failing to set up the file descriptor to test.  Restore this
behavior to avoid hitting failures when hugetlb isn't configured.

Link: https://lkml.kernel.org/r/20250605-selftest-mm-gup-longterm-tweaks-v1-1-2fae34b05958@kernel.org
Fies: 66bce7afbaca ("selftests/mm: fix test result reporting in gup_longterm")
Signed-off-by: Mark Brown <broonie@kernel.org>
Reported-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Closes: https://lkml.kernel.org/r/a76fc252-0fe3-4d4b-a9a1-4a2895c2680d@lucifer.local
Cc: David Hildenbrand <david@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>

Re: [PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

Posted by David Hildenbrand 6 months, 2 weeks ago

On 06.06.25 03:04, Andrew Morton wrote:
> On Thu, 05 Jun 2025 22:34:31 +0100 Mark Brown <broonie@kernel.org> wrote:
> 
>> Unlike the other cases gup_longterm's memfd tests previously skipped the
>> test when failing to set up the file descriptor to test, restore this
>> behaviour.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
> 
> I added a bunch of stuff to this.  Please check?
> 
> 
> From: Mark Brown <broonie@kernel.org>
> Subject: selftests/mm: skip failed memfd setups in gup_longterm
> Date: Thu, 05 Jun 2025 22:34:31 +0100
> 
> Unlike the other cases gup_longterm's memfd tests previously skipped the
> test when failing to set up the file descriptor to test.  Restore this
> behavior to avoid hitting failures when hugetlb isn't configured.
> 
> Link: https://lkml.kernel.org/r/20250605-selftest-mm-gup-longterm-tweaks-v1-1-2fae34b05958@kernel.org
> Fies: 66bce7afbaca ("selftests/mm: fix test result reporting in gup_longterm")

"Fixes:"

> Signed-off-by: Mark Brown <broonie@kernel.org>
> Reported-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Closes: https://lkml.kernel.org/r/a76fc252-0fe3-4d4b-a9a1-4a2895c2680d@lucifer.local
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>
> 

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb