[PATCH v1 0/5] rust: Add ACPI match table support for Rust drivers

Igor Korotin posted 5 patches 6 months, 2 weeks ago
Only 3 patches received!
There is a newer version of this series
MAINTAINERS                          |  2 +
rust/bindings/bindings_helper.h      |  1 +
rust/helpers/helpers.c               |  1 +
rust/helpers/of.c                    |  6 +++
rust/kernel/acpi.rs                  | 62 ++++++++++++++++++++++++++++
rust/kernel/driver.rs                | 58 ++++++++++++++++++++++++--
rust/kernel/lib.rs                   |  1 +
rust/kernel/platform.rs              | 17 +++++++-
samples/rust/rust_driver_platform.rs | 41 +++++++++++++++++-
9 files changed, 183 insertions(+), 6 deletions(-)
create mode 100644 rust/helpers/of.c
create mode 100644 rust/kernel/acpi.rs
[PATCH v1 0/5] rust: Add ACPI match table support for Rust drivers
Posted by Igor Korotin 6 months, 2 weeks ago
This patch series introduces support for ACPI match tables in Rust 
drivers.

Currently, Rust abstractions support only Open Firmware (OF) device 
matching. This series extends the driver model to support ACPI-based 
matching, enabling Rust drivers to bind to ACPI-described devices.

Changes include:
  - A new `acpi::DeviceId` abstraction for working with 
   `struct acpi_device_id`.
  - A helper function `is_of_node()` for determining fwnode types.
  - Updates to the core `Adapter` trait and `platform::Driver` to support
    optional ACPI ID tables.
  - A sample implementation in the Rust platform driver, demonstrating 
    multi-bus matching.

This is especially useful for writing drivers that work across platforms 
using both OF and ACPI.

Tested using QEMU with a custom SSDT that creates an ACPI device matching
the sample Rust platform driver.

Igor Korotin (5):
  rust: acpi: add `acpi::DeviceId` abstraction
  rust: helpers: Add `is_of_node` helper function
  rust: driver: Add ACPI id table support to Adapter trait
  rust: platform: Add ACPI match table support to `Driver` trait
  samples: rust: add ACPI match table example to platform driver

 MAINTAINERS                          |  2 +
 rust/bindings/bindings_helper.h      |  1 +
 rust/helpers/helpers.c               |  1 +
 rust/helpers/of.c                    |  6 +++
 rust/kernel/acpi.rs                  | 62 ++++++++++++++++++++++++++++
 rust/kernel/driver.rs                | 58 ++++++++++++++++++++++++--
 rust/kernel/lib.rs                   |  1 +
 rust/kernel/platform.rs              | 17 +++++++-
 samples/rust/rust_driver_platform.rs | 41 +++++++++++++++++-
 9 files changed, 183 insertions(+), 6 deletions(-)
 create mode 100644 rust/helpers/of.c
 create mode 100644 rust/kernel/acpi.rs

-- 
2.43.0
Re: [PATCH v1 0/5] rust: Add ACPI match table support for Rust drivers
Posted by Danilo Krummrich 6 months, 2 weeks ago
On Wed, Jun 04, 2025 at 01:29:39PM +0100, Igor Korotin wrote:
> This patch series introduces support for ACPI match tables in Rust 
> drivers.
> 
> Currently, Rust abstractions support only Open Firmware (OF) device 
> matching. This series extends the driver model to support ACPI-based 
> matching, enabling Rust drivers to bind to ACPI-described devices.
> 
> Changes include:
>   - A new `acpi::DeviceId` abstraction for working with 
>    `struct acpi_device_id`.
>   - A helper function `is_of_node()` for determining fwnode types.
>   - Updates to the core `Adapter` trait and `platform::Driver` to support
>     optional ACPI ID tables.
>   - A sample implementation in the Rust platform driver, demonstrating 
>     multi-bus matching.
> 
> This is especially useful for writing drivers that work across platforms 
> using both OF and ACPI.
> 
> Tested using QEMU with a custom SSDT that creates an ACPI device matching
> the sample Rust platform driver.

Thanks this is great!

Unfortunately, it seems that something went wrong sending this patch series.
Patches 3 and 5 are missing on my end (and on the corresponding lists as well).
Can you please resend?

Also, technically this series is a v2; patch 1 differs from the one you sent
originally -- please include a changelog.
Re: [PATCH v1 0/5] rust: Add ACPI match table support for Rust drivers
Posted by Igor Korotin 6 months, 2 weeks ago
> Thanks this is great!
> 
> Unfortunately, it seems that something went wrong sending this patch series.
> Patches 3 and 5 are missing on my end (and on the corresponding lists as well).

Yes, I know. Gmail has blocked me from sending any letters. I probably hit
some limit. It will likely unblock me sometime today or tomorrow.

> Also, technically this series is a v2; patch 1 differs from the one you sent
> originally -- please include a changelog.

Because of this Gmail issue, I need to clarify the right course of 
action to avoid being blocked again:
Should I resend the whole series as PATCH v2 with a changelog?

Thanks
Igor
Re: [PATCH v1 0/5] rust: Add ACPI match table support for Rust drivers
Posted by Danilo Krummrich 6 months, 2 weeks ago
On Thu, Jun 05, 2025 at 02:57:21PM +0100, Igor Korotin wrote:
> Should I resend the whole series as PATCH v2 with a changelog?

Yes, please do so.