iio: adc: ti-ads131e08: Fix spelling mistake "tweek" -> "tweak"

[PATCH][next] iio: adc: ti-ads131e08: Fix spelling mistake "tweek" -> "tweak"

Posted by Colin Ian King 6 months, 2 weeks ago

There is a spelling mistake in variable tweek_offset and in comment
blocks. Fix these.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/iio/adc/ti-ads131e08.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/ti-ads131e08.c b/drivers/iio/adc/ti-ads131e08.c
index 085f0d6fb39e..b18f30d3fdbe 100644
--- a/drivers/iio/adc/ti-ads131e08.c
+++ b/drivers/iio/adc/ti-ads131e08.c
@@ -625,7 +625,7 @@ static irqreturn_t ads131e08_trigger_handler(int irq, void *private)
 	 * 16 bits of data into the buffer.
 	 */
 	unsigned int num_bytes = ADS131E08_NUM_DATA_BYTES(st->data_rate);
-	u8 tweek_offset = num_bytes == 2 ? 1 : 0;
+	u8 tweak_offset = num_bytes == 2 ? 1 : 0;
 
 	if (iio_trigger_using_own(indio_dev))
 		ret = ads131e08_read_data(st, st->readback_len);
@@ -640,25 +640,25 @@ static irqreturn_t ads131e08_trigger_handler(int irq, void *private)
 		dest = st->tmp_buf.data + i * ADS131E08_NUM_STORAGE_BYTES;
 
 		/*
-		 * Tweek offset is 0:
+		 * Tweak offset is 0:
 		 * +---+---+---+---+
 		 * |D0 |D1 |D2 | X | (3 data bytes)
 		 * +---+---+---+---+
 		 *  a+0 a+1 a+2 a+3
 		 *
-		 * Tweek offset is 1:
+		 * Tweak offset is 1:
 		 * +---+---+---+---+
 		 * |P0 |D0 |D1 | X | (one padding byte and 2 data bytes)
 		 * +---+---+---+---+
 		 *  a+0 a+1 a+2 a+3
 		 */
-		memcpy(dest + tweek_offset, src, num_bytes);
+		memcpy(dest + tweak_offset, src, num_bytes);
 
 		/*
 		 * Data conversion from 16 bits of data to 24 bits of data
 		 * is done by sign extension (properly filling padding byte).
 		 */
-		if (tweek_offset)
+		if (tweak_offset)
 			*dest = *src & BIT(7) ? 0xff : 0x00;
 
 		i++;
-- 
2.49.0

Re: [PATCH][next] iio: adc: ti-ads131e08: Fix spelling mistake "tweek" -> "tweak"

Posted by Andy Shevchenko 6 months, 2 weeks ago

On Tue, Jun 03, 2025 at 05:57:06PM +0100, Colin Ian King wrote:
> There is a spelling mistake in variable tweek_offset and in comment
> blocks. Fix these.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

Datasheet doesn't give any special term for this, so I think the patch
is correct. OTOH, the dictionary defines tweek as "A form of atmospherics
(radio interference) produced when the high-frequency components reach
the receiver before the low-frequency components." which is somehow might be
related (like high byte goes before low or vise versa).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH][next] iio: adc: ti-ads131e08: Fix spelling mistake "tweek" -> "tweak"

Posted by Jonathan Cameron 6 months, 2 weeks ago

On Wed, 4 Jun 2025 18:30:13 +0300
Andy Shevchenko <andy@kernel.org> wrote:

> On Tue, Jun 03, 2025 at 05:57:06PM +0100, Colin Ian King wrote:
> > There is a spelling mistake in variable tweek_offset and in comment
> > blocks. Fix these.  
> 
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 
> Datasheet doesn't give any special term for this, so I think the patch
> is correct. OTOH, the dictionary defines tweek as "A form of atmospherics
> (radio interference) produced when the high-frequency components reach
> the receiver before the low-frequency components." which is somehow might be
> related (like high byte goes before low or vise versa).
> 

I think this is just tweak so applied.  (I'd never heard of tweek so interesting
to know about that one!)