mm: Kconfig: Use verb *use* in plural form in description

[PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by Paul Menzel 8 months, 1 week ago

*workloads* is plural requiring the verb *use* in plural form.

Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
Reading the sentence it feels like, something is missing before the
*please*, but I am no native speaker.

 mm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/Kconfig b/mm/Kconfig
index f8bb8f070d0d..e3a07687ed0b 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
 	  or MAX_PAGE_ORDER.
 
 	  Reducing pageblock order can negatively impact THP generation
-	  success rate. If your workloads uses THP heavily, please use this
+	  success rate. If your workloads use THP heavily, please use this
 	  option with caution.
 
 	  Don't change if unsure.
-- 
2.49.0

Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by Zi Yan 8 months, 1 week ago

On 3 Jun 2025, at 2:13, Paul Menzel wrote:

> *workloads* is plural requiring the verb *use* in plural form.
>
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.
>
>  mm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks.

Reviewed-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi

Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by Lorenzo Stoakes 8 months, 1 week ago

On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> *workloads* is plural requiring the verb *use* in plural form.
>
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")

I think a fixes is unnecessary here :) I mean strictly true, but we don't
need to backport a typo fix :P

> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.

Seems ok to me as a native speaker! Though I don't claim to be the most
erudite...

>
>  mm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f8bb8f070d0d..e3a07687ed0b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
>  	  or MAX_PAGE_ORDER.
>
>  	  Reducing pageblock order can negatively impact THP generation
> -	  success rate. If your workloads uses THP heavily, please use this
> +	  success rate. If your workloads use THP heavily, please use this
>  	  option with caution.
>
>  	  Don't change if unsure.
> --
> 2.49.0
>

Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by David Hildenbrand 8 months, 1 week ago

On 03.06.25 11:31, Lorenzo Stoakes wrote:
> On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
>> *workloads* is plural requiring the verb *use* in plural form.
>>
>> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> 
> I think a fixes is unnecessary here :) I mean strictly true, but we don't
> need to backport a typo fix :P
> 
>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> 
>> ---
>> Reading the sentence it feels like, something is missing before the
>> *please*, but I am no native speaker.
> 
> Seems ok to me as a native speaker! Though I don't claim to be the most
> erudite...
> 
>>
>>   mm/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index f8bb8f070d0d..e3a07687ed0b 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
>>   	  or MAX_PAGE_ORDER.
>>
>>   	  Reducing pageblock order can negatively impact THP generation
>> -	  success rate. If your workloads uses THP heavily, please use this
>> +	  success rate. If your workloads use THP heavily, please use this

Should this be "use THPs" ?

-- 
Cheers,

David / dhildenb

Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by Lorenzo Stoakes 8 months, 1 week ago

On Tue, Jun 03, 2025 at 11:38:47AM +0200, David Hildenbrand wrote:
> On 03.06.25 11:31, Lorenzo Stoakes wrote:
> > On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> > > *workloads* is plural requiring the verb *use* in plural form.
> > >
> > > Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> >
> > I think a fixes is unnecessary here :) I mean strictly true, but we don't
> > need to backport a typo fix :P
> >
> > > Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >
> > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> >
> > > ---
> > > Reading the sentence it feels like, something is missing before the
> > > *please*, but I am no native speaker.
> >
> > Seems ok to me as a native speaker! Though I don't claim to be the most
> > erudite...
> >
> > >
> > >   mm/Kconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mm/Kconfig b/mm/Kconfig
> > > index f8bb8f070d0d..e3a07687ed0b 100644
> > > --- a/mm/Kconfig
> > > +++ b/mm/Kconfig
> > > @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
> > >   	  or MAX_PAGE_ORDER.
> > >
> > >   	  Reducing pageblock order can negatively impact THP generation
> > > -	  success rate. If your workloads uses THP heavily, please use this
> > > +	  success rate. If your workloads use THP heavily, please use this
>
> Should this be "use THPs" ?

I would say not, because in this context it's 'THP' as a feature rather than as
individiual transparent huge pages.

But, to repeat, I am far from erudite ;)

>
> --
> Cheers,
>
> David / dhildenb
>

Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

Posted by Mike Rapoport 8 months, 1 week ago

On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> *workloads* is plural requiring the verb *use* in plural form.
> 
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.
> 
>  mm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f8bb8f070d0d..e3a07687ed0b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
>  	  or MAX_PAGE_ORDER.
>  
>  	  Reducing pageblock order can negatively impact THP generation
> -	  success rate. If your workloads uses THP heavily, please use this
> +	  success rate. If your workloads use THP heavily, please use this
>  	  option with caution.
>  
>  	  Don't change if unsure.
> -- 
> 2.49.0
> 

-- 
Sincerely yours,
Mike.