[v1] net: bcmgenet: add support for GRO software interrupt coalescing

[PATCH v1 0/2] net: bcmgenet: add support for GRO software interrupt coalescing

Posted by Zak Kemble 8 months, 2 weeks ago

Hey, these patches enable support for software IRQ coalescing and GRO
aggregation and applies conservative defaults which can help improve
system and network performance by reducing the number of hardware
interrupts and improving GRO aggregation ratio.

Zak Kemble (2):
  net: bcmgenet: use napi_complete_done return value
  net: bcmgenet: enable GRO software interrupt coalescing by default

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.39.5

Re: [PATCH v1 0/2] net: bcmgenet: add support for GRO software interrupt coalescing

Posted by Florian Fainelli 8 months, 1 week ago

Hi Zak,

On 5/31/25 15:48, Zak Kemble wrote:
> Hey, these patches enable support for software IRQ coalescing and GRO
> aggregation and applies conservative defaults which can help improve
> system and network performance by reducing the number of hardware
> interrupts and improving GRO aggregation ratio.

Without this patch, seeing the following with an iperf3 server running 
at a gigabit link:

00:18:19     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
  %guest   %idle
00:18:20     all    0.53    0.00    9.36    0.00    8.56   18.98    0.00 
    0.00   62.57

and with your patches applied:

00:00:56     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
  %guest   %idle
00:00:57     all    0.00    0.00    3.29    0.00    1.01    7.34    0.00 
    0.00   88.35

so definitively helping, thanks!

Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

You will have to repost once net-next opens though:

https://patchwork.hopto.org/net-next.html

Thanks!
-- 
Florian

Re: [PATCH v1 0/2] net: bcmgenet: add support for GRO software interrupt coalescing

Posted by Florian Fainelli 8 months ago

On 6/2/25 12:00, Florian Fainelli wrote:
> Hi Zak,
> 
> On 5/31/25 15:48, Zak Kemble wrote:
>> Hey, these patches enable support for software IRQ coalescing and GRO
>> aggregation and applies conservative defaults which can help improve
>> system and network performance by reducing the number of hardware
>> interrupts and improving GRO aggregation ratio.
> 
> Without this patch, seeing the following with an iperf3 server running 
> at a gigabit link:
> 
> 00:18:19     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
>   %guest   %idle
> 00:18:20     all    0.53    0.00    9.36    0.00    8.56   18.98    0.00 
>     0.00   62.57
> 
> and with your patches applied:
> 
> 00:00:56     CPU    %usr   %nice    %sys %iowait    %irq   %soft  %steal 
>   %guest   %idle
> 00:00:57     all    0.00    0.00    3.29    0.00    1.01    7.34    0.00 
>     0.00   88.35
> 
> so definitively helping, thanks!
> 
> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> 
> You will have to repost once net-next opens though:
> 
> https://patchwork.hopto.org/net-next.html
> 
> Thanks!

Zak, do you mind re-posting now that net-next is open? Thanks!
-- 
Florian