kernel/nsproxy: Minor nsproxy code simplification

[PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Joel Savitz 6 months, 2 weeks ago

The first patch removes an unnecessary guard by the same logic as
commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").

The second patch fixes the total ordering of resource acquisition
in validate_nsset().

The third patch implements usage of the cleanup helper added by commit
d057c108155a ("nsproxy: add a cleanup helper for nsproxy").

Joel Savitz (3):
  kernel/nsproxy: remove unnecessary guard in validate_nsset()
  kernel/nsproxy: fix put_*() call ordering in validate_nsset()
  kernel/nsproxy: utilize cleanup helper for nsproxy references

 kernel/nsproxy.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

-- 
2.45.2

Re: [PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Christian Brauner 5 months ago

On Fri, 30 May 2025 16:03:03 -0400, Joel Savitz wrote:
> The first patch removes an unnecessary guard by the same logic as
> commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").
> 
> The second patch fixes the total ordering of resource acquisition
> in validate_nsset().
> 
> The third patch implements usage of the cleanup helper added by commit
> d057c108155a ("nsproxy: add a cleanup helper for nsproxy").
> 
> [...]

Applied to the kernel-6.17.nsproxy branch of the vfs/vfs.git tree.
Patches in the kernel-6.17.nsproxy branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: kernel-6.17.nsproxy

[1/3] kernel/nsproxy: remove unnecessary guard in validate_nsset()
      https://git.kernel.org/vfs/vfs/c/e07195e0a5c3
[2/3] kernel/nsproxy: fix put_*() call ordering in validate_nsset()
      https://git.kernel.org/vfs/vfs/c/17e48a8cfd75
[3/3] kernel/nsproxy: utilize cleanup helper for nsproxy references
      https://git.kernel.org/vfs/vfs/c/04555045c014

Re: [PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Joel Savitz 6 months, 1 week ago

On Fri, May 30, 2025 at 4:03 PM Joel Savitz <jsavitz@redhat.com> wrote:
>
> The first patch removes an unnecessary guard by the same logic as
> commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").
>
> The second patch fixes the total ordering of resource acquisition
> in validate_nsset().
>
> The third patch implements usage of the cleanup helper added by commit
> d057c108155a ("nsproxy: add a cleanup helper for nsproxy").
>
> Joel Savitz (3):
>   kernel/nsproxy: remove unnecessary guard in validate_nsset()
>   kernel/nsproxy: fix put_*() call ordering in validate_nsset()
>   kernel/nsproxy: utilize cleanup helper for nsproxy references
>
>  kernel/nsproxy.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> --
> 2.45.2
>

ping

Re: [PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Joel Savitz 6 months ago

On Mon, Jun 9, 2025 at 10:23 AM Joel Savitz <jsavitz@redhat.com> wrote:
>
> On Fri, May 30, 2025 at 4:03 PM Joel Savitz <jsavitz@redhat.com> wrote:
> >
> > The first patch removes an unnecessary guard by the same logic as
> > commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").
> >
> > The second patch fixes the total ordering of resource acquisition
> > in validate_nsset().
> >
> > The third patch implements usage of the cleanup helper added by commit
> > d057c108155a ("nsproxy: add a cleanup helper for nsproxy").
> >
> > Joel Savitz (3):
> >   kernel/nsproxy: remove unnecessary guard in validate_nsset()
> >   kernel/nsproxy: fix put_*() call ordering in validate_nsset()
> >   kernel/nsproxy: utilize cleanup helper for nsproxy references
> >
> >  kernel/nsproxy.c | 12 +++---------
> >  1 file changed, 3 insertions(+), 9 deletions(-)
> >
> > --
> > 2.45.2
> >
>
> ping

ping 2

Re: [PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Joel Savitz 5 months, 2 weeks ago

On Wed, Jun 18, 2025 at 3:49 PM Joel Savitz <jsavitz@redhat.com> wrote:
>
> On Mon, Jun 9, 2025 at 10:23 AM Joel Savitz <jsavitz@redhat.com> wrote:
> >
> > On Fri, May 30, 2025 at 4:03 PM Joel Savitz <jsavitz@redhat.com> wrote:
> > >
> > > The first patch removes an unnecessary guard by the same logic as
> > > commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").
> > >
> > > The second patch fixes the total ordering of resource acquisition
> > > in validate_nsset().
> > >
> > > The third patch implements usage of the cleanup helper added by commit
> > > d057c108155a ("nsproxy: add a cleanup helper for nsproxy").
> > >
> > > Joel Savitz (3):
> > >   kernel/nsproxy: remove unnecessary guard in validate_nsset()
> > >   kernel/nsproxy: fix put_*() call ordering in validate_nsset()
> > >   kernel/nsproxy: utilize cleanup helper for nsproxy references
> > >
> > >  kernel/nsproxy.c | 12 +++---------
> > >  1 file changed, 3 insertions(+), 9 deletions(-)
> > >
> > > --
> > > 2.45.2
> > >
> >
> > ping
>
> ping 2

ping 3

Re: [PATCH 0/3] kernel/nsproxy: Minor nsproxy code simplification

Posted by Joel Savitz 5 months, 1 week ago

On Tue, Jul 1, 2025 at 12:41 PM Joel Savitz <jsavitz@redhat.com> wrote:
>
> On Wed, Jun 18, 2025 at 3:49 PM Joel Savitz <jsavitz@redhat.com> wrote:
> >
> > On Mon, Jun 9, 2025 at 10:23 AM Joel Savitz <jsavitz@redhat.com> wrote:
> > >
> > > On Fri, May 30, 2025 at 4:03 PM Joel Savitz <jsavitz@redhat.com> wrote:
> > > >
> > > > The first patch removes an unnecessary guard by the same logic as
> > > > commit 5caa2d89b7f1 ("kernel/nsproxy: remove unnecessary guards").
> > > >
> > > > The second patch fixes the total ordering of resource acquisition
> > > > in validate_nsset().
> > > >
> > > > The third patch implements usage of the cleanup helper added by commit
> > > > d057c108155a ("nsproxy: add a cleanup helper for nsproxy").
> > > >
> > > > Joel Savitz (3):
> > > >   kernel/nsproxy: remove unnecessary guard in validate_nsset()
> > > >   kernel/nsproxy: fix put_*() call ordering in validate_nsset()
> > > >   kernel/nsproxy: utilize cleanup helper for nsproxy references
> > > >
> > > >  kernel/nsproxy.c | 12 +++---------
> > > >  1 file changed, 3 insertions(+), 9 deletions(-)
> > > >
> > > > --
> > > > 2.45.2
> > > >
> > >
> > > ping
> >
> > ping 2
>
> ping 3

ping 4