[PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status

Siddharth Vadapalli posted 13 patches 6 months, 3 weeks ago
There is a newer version of this series
[PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status
Posted by Siddharth Vadapalli 6 months, 3 weeks ago
Now that the SoC file "k3-am65-mcu.dtsi" disables the "mcu_cpsw" node by
default, following the existing convention of disabling nodes in the SoC
file, remove the redundant section for disabling the "mcu_cpsw" node.

Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index e5136ed94765..48e740eb0088 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -475,10 +475,6 @@ &main_i2c3 {
 	#size-cells = <0>;
 };
 
-&mcu_cpsw {
-	status = "disabled";
-};
-
 &sdhci1 {
 	status = "okay";
 	pinctrl-names = "default";
-- 
2.34.1
Re: [PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status
Posted by Krzysztof Kozlowski 6 months, 3 weeks ago
On 29/05/2025 15:34, Siddharth Vadapalli wrote:
> Now that the SoC file "k3-am65-mcu.dtsi" disables the "mcu_cpsw" node by
> default, following the existing convention of disabling nodes in the SoC
> file, remove the redundant section for disabling the "mcu_cpsw" node.

It became redundant when you disabled it, so this must be part of that
commit. Do not create redundant code with some artificial split of one
logical work.


Best regards,
Krzysztof
Re: [PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status
Posted by Siddharth Vadapalli 6 months, 2 weeks ago
On Thu, May 29, 2025 at 03:38:51PM +0200, Krzysztof Kozlowski wrote:
> On 29/05/2025 15:34, Siddharth Vadapalli wrote:
> > Now that the SoC file "k3-am65-mcu.dtsi" disables the "mcu_cpsw" node by
> > default, following the existing convention of disabling nodes in the SoC
> > file, remove the redundant section for disabling the "mcu_cpsw" node.
> 
> It became redundant when you disabled it, so this must be part of that
> commit. Do not create redundant code with some artificial split of one
> logical work.

Sure, I will squash the commits. I tend to split the commits since it is
easier for maintainers to squash commits (if required) than to split them.
Thank you for reviewing the patch.

Regards,
Siddharth.